Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 807
    • Issues 807
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 54
    • Merge Requests 54
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !433

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana] Preferred hashtag remembered in local storage #1366

closes #1302

test that your selection for preferred is remembered in local storage.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/default-preferred-state-1366 origin/fix/default-preferred-state-1366

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/default-preferred-state-1366

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/default-preferred-state-1366 into master
The source branch is 61 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70737719 passed for 04c502a3 on fix/default-preferred-state-1366
          Requires 2 more approvals from Devs and Deployers.
          Emiliano Balbuena
          Emiliano Balbuena
          Brian Hatchet
          Brian Hatchet
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1302

          Mentions #1366 (closed)

          Deletes source branch

          • Discussion 4
          • Commits 3
          • Pipelines 3
          • Changes 1
          1/1 thread resolved
          • Loading...
          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding · 2 days ago
            Owner

            Screen_Shot_2019-07-09_at_10.19.00_PM

            all is not being set on the API. The button may be saving but you need to toggle on/off to get the list component to realise.

          • Mark Harding @markeharding added MR::Requires Changes label 2 days ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • 1b0e9eec - update for feedback

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 day ago
            Developer

            Okay, I see what you mean. added that in.

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 23 hours ago
            Resolved by Ben Hayward 2 hours ago
          • Ben Hayward @benhayward.ben added 1 commit 2 hours ago

            added 1 commit

            • 04c502a3 - Emit event on load to set querystring properly

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all threads 2 hours ago

            resolved all threads

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label and removed MR::Requires Changes label 2 hours ago

            added MR::Awaiting Review label and removed MR::Requires Changes label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/front!433