Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 151
    • Issues 151
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !267

Open
Opened 3 hours ago by Juan Manuel Solaro@juanmsolaro
  • Report abuse
Report abuse

WIP: (feat) Specify From minds.com on sms messages

Added "from minds.com:..." to message body.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/add-from-sms-message origin/feat/add-from-sms-message

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/add-from-sms-message

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/add-from-sms-message into master
The source branch is 31 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70518819 failed for e23d3d4f on feat/add-from-sms-message
          Requires 2 more approvals from Devs and Deployers.
          Ben Hayward
          Ben Hayward
          Rami Albatal
          Rami Albatal
          Emiliano Balbuena
          Emiliano Balbuena
          Brian Hatchet
          Brian Hatchet
          Martin Santangelo
          Martin Santangelo
          This is a Work in Progress
          You can merge this merge request manually using the
          • Discussion 3
          • Commits 1
          • Pipelines 1
          • Changes 2
          0/1 thread resolved
          • Loading...
          • Juan Manuel Solaro
            Juan Manuel Solaro @juanmsolaro · 3 hours ago
            Developer

            It's the message ok? @markeharding

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 hours ago
            Core/SMS/Services/Twilio.php
            55 55 try {
            56 56 $result = $this->client->messages->create(
            57 57 $number, [
            58 'from' => $this->config['from'],
            59 'body' => $message,
            58 'from' => 'Minds',
            59 'body' => 'From Minds.com: Your code is '. $message,
            • Mark Harding
              Mark Harding @markeharding · 2 hours ago
              Owner

              'Your code is ' should be moved to the higher level.

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding · 2 hours ago
            Owner

            Looks like we have some failing tests too

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Ben Hayward
          user avatar
          Rami Albatal
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          Reference: minds/engine!267