Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 59
    • Merge Requests 59
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !405

Closed
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

Boost button mobile offscreen #1357

Closes #1357

Screenshot_20190703-204252_Brave

Screenshot_20190703-204316_BraveCloses #1357

image

Edited 6 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/mob-boost-btn-offscreen-1357 origin/fix/mob-boost-btn-offscreen-1357

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/mob-boost-btn-offscreen-1357

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/mob-boost-btn-offscreen-1357 into master
  • Email patches
  • Plain diff
Pipeline #69584838 passed with warnings for 99e8b38a on fix/mob-boost-btn-offscreen-1357
          Requires approval from Deployers. Approved by
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding

          Closed by Mark Harding 33 minutes ago

          The changes were not merged into master

          Did not close #1357

          Deletes source branch

          • Discussion 4
          • Commits 4
          • Pipelines 6
          • Changes 2
          1/1 thread resolved
          • Loading...
          • Mark Harding
            Mark Harding @markeharding · 1 week ago
            Owner

            Screen_Shot_2019-07-02_at_8.53.14_PM

          • Mark Harding @markeharding added MR::Requires Changes label 1 week ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • d795e9b4 - Added in poiner on a-links in group chat

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 6 days ago

            added 1 commit

            • f6437d8c - updated to work on smaller devices

            Compare with previous version

          • Ben Hayward @benhayward.ben added 2 commits 6 days ago

            added 2 commits

            • 61383a5c - added missing changes
            • b0e70291 - Added missing changes

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 6 days ago

            changed the description

          • Ben Hayward
            Ben Hayward @benhayward.ben · 6 days ago
            Developer

            Took more away to support smaller phones.

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 6 days ago
            Resolved by Ben Hayward 5 days ago
          • Ben Hayward @benhayward.ben added 1 commit 5 days ago

            added 1 commit

            • 99e8b38a - Update creator.component.scss

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all threads 5 days ago

            resolved all threads

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label and removed MR::Requires Changes label 5 days ago

            added MR::Awaiting Review label and removed MR::Requires Changes label

          • Marcelo Rivera @eiennohi approved this merge request 5 days ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding · 33 minutes ago
            Owner

            closing this as the new changes we made have actually meant we need a scroll. we can revisit in the future

          • Mark Harding @markeharding closed 33 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/front!405