Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 59
    • Merge Requests 59
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !435

Merged
Opened 1 day ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

(fix) Display 'No Results' text when searching help questions instead of no feedback - fixes #1501

Fixes #1501 (closed) by adding 'No Results' text when searching help questions instead of no feedback

Request to merge fix/1501-help-results into master
  • Email patches
  • Plain diff
Pipeline #70308718 passed for b9d287e6 on fix/1501-help-results
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Ben Hayward
          Ben Hayward
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera

          Merged by Mark Harding 21 minutes ago

          The changes were merged into master with 9869abaa

          The source branch has been deleted

          Closed #1501 (closed)

          Pipeline #70367609 running for 9869abaa on master
                • Discussion 3
                • Commits 2
                • Pipelines 2
                • Changes 3
                0/1 thread resolved
                • Loading...
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 day ago
                  Last updated by Guy Thouret 5 hours ago
                  src/app/modules/helpdesk/dashboard/dashboard.component.html
                  27 27 </div>
                  28 28 </div>
                  29 29
                  30 <div *ngIf="noResults"
                  31 class="m-helpdeskSearch__results m-border"
                  32 >
                  33 <div class="m-helpdeskSearch__result">
                  • Brian Hatchet
                    Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                    Maintainer

                    This should have one of our translation @@markers

                  • Guy Thouret
                    Guy Thouret @gthouret · 5 hours ago
                    Developer

                    I added i18n tag to the element with 'no results' text, does that satisfy?

                  • Please register or sign in to reply
                • Guy Thouret @gthouret added 1 commit 5 hours ago

                  added 1 commit

                  • b9d287e6 - (fix): Add missing i18n tag to hekpdesk dashboard search result

                  Compare with previous version

                • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 hours ago

                  approved this merge request

                • Ben Hayward @benhayward.ben mentioned in issue minds#643 (closed) 2 hours ago

                  mentioned in issue minds#643 (closed)

                • Ben Hayward @benhayward.ben approved this merge request 2 hours ago

                  approved this merge request

                • Mark Harding @markeharding approved this merge request 21 minutes ago

                  approved this merge request

                • Mark Harding @markeharding merged 21 minutes ago

                  merged

                • Mark Harding @markeharding mentioned in commit 9869abaa 21 minutes ago

                  mentioned in commit 9869abaa

                • Mark Harding
                  Mark Harding @markeharding · 21 minutes ago
                  Owner

                  @gthouret congrats on first checkin!

                • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                Please register or sign in to reply
                0 Assignees
                None
                Assign to
                None
                Milestone
                None
                Assign milestone
                None
                Time tracking
                No estimate or time spent
                0
                Labels
                None
                Assign labels
                • View project labels
                Lock merge request
                Unlocked
                7
                7 participants
                user avatar
                Emiliano Balbuena
                user avatar
                Martin Santangelo
                user avatar
                Marcelo Rivera
                user avatar
                Mark Harding
                user avatar
                Ben Hayward
                user avatar
                Brian Hatchet
                user avatar
                Guy Thouret
                Reference: minds/front!435

                Revert this merge request

                This will create a new commit in order to revert the existing changes.

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.

                Cherry-pick this merge request

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.