Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 148
    • Issues 148
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !258

Merged
Opened 1 day ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Feat/email schema 187

Request to merge feat/email-schema-187 into master
  • Email patches
  • Plain diff
Pipeline #70150301 failed for 18a4c6e4 on feat/email-schema-187
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal

          Merged by Mark Harding 57 minutes ago

          The changes were merged into master with 5797d6ea

          The source branch has been deleted

          Pipeline #70329877 passed for 5797d6ea on master
                  • Discussion 3
                  • Commits 3
                  • Pipelines 2
                  • Changes 20
                  0/2 threads resolved
                  • Loading...
                  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Interesting Iguana 1 day ago

                    changed milestone to %sprint: Interesting Iguana

                  • Brian Hatchet
                    Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 day ago
                    Core/Email/Campaigns/EmailCampaign.php
                    65 66
                    66 67 return true;
                    67 68 }
                    69
                    70 /**
                    71 * Returns the short name of the class as the template name.
                    72 */
                    73 public function getEmailCampaignId()
                    74 {
                    75 return (new \ReflectionClass($this))->getShortName();
                    • Brian Hatchet
                      Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                      Maintainer

                      This still requires @markeharding 's approval. FYI: @edgebal this was the only unresolved issue on the previous MR

                    • Please register or sign in to reply
                    • Mark Harding
                      Mark Harding @markeharding · 1 day ago
                      Owner

                      @brianhatchet can you make sure the schema is in the provisioner cql file?

                    • Collapse replies
                    • Brian Hatchet
                      Brian Hatchet :speech_balloon: @brianhatchet · 22 hours ago
                      Maintainer

                      Added

                    • Please register or sign in to reply
                  • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 22 hours ago

                    added 1 commit

                    • 18a4c6e4 - CR changes, adding table to provisioner

                    Compare with previous version

                  • Mark Harding @markeharding approved this merge request 59 minutes ago

                    approved this merge request

                  • Mark Harding @markeharding merged 57 minutes ago

                    merged

                  • Mark Harding @markeharding mentioned in commit 5797d6ea 57 minutes ago

                    mentioned in commit 5797d6ea

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  Assignee
                  Brian Hatchet's avatar Brian Hatchet @brianhatchet
                  Assign to
                  sprint: Interesting Iguana
                  Milestone
                  sprint: Interesting Iguana
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  0
                  Labels
                  None
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Martin Santangelo
                  user avatar
                  Ben Hayward
                  user avatar
                  Marcelo Rivera
                  user avatar
                  Rami Albatal
                  user avatar
                  Brian Hatchet
                  user avatar
                  Mark Harding
                  Reference: minds/engine!258

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.