Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 148
    • Issues 148
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #264

Closed
Open
Opened 4 months ago by Faizan Khan@FaizanJKhan
  • Report abuse
  • New issue
Report abuse New issue

Reduce MetaMask Default Suggested Gas

  • Right now, gas fee suggestions are way higher than they need to be for an OnChain boost (MetaMask default is 40 GWEI, ~$1.30+)
  • When users OnChain boost, we can set the default suggestion in MetaMask to something lower and more reasonable.

Here is an approach that @benhayward.ben discovered: https://github.com/MetaMask/metamask-extension/issues/1473

We can decide what threshold we want the default to be at. I have safely cut the fee by around 70% and it still settled in under a minute. We can cut it by ~40-50% of the default suggestion to be safe. This should run in parallel with our onchain updates.

@jotto141 @ottman @markeharding

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 4 months ago by Faizan Khan

Related issues
0

    • Faizan Khan @FaizanJKhan added to epic &4 (closed) 4 months ago

      added to epic &4 (closed)

    • Faizan Khan @FaizanJKhan changed the description 2 times within 2 minutes 4 months ago

      changed the description 2 times within 2 minutes

    • Faizan Khan @FaizanJKhan changed due date to March 15, 2019 4 months ago

      changed due date to March 15, 2019

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      We are actually setting the default gas fee to 40 GWei, which is just under double the current gas fee of 23 (https://etherscan.io/gasTracker). It's very volatile though so I think there needs to be some kind of a buffer.

      Smart contract interactions generally need higher gas fees than just standard ethereum transactions. If its too low then the transactions can get forgotten about. If somebody replaces the transactions by providing a higher gas fee later, the transaction will succeed but Minds is expecting a different TX hash and this causes issues on our end.

      What gas fee are you generally using now?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 4 months ago
      Developer

      Why not set the gas price dynamically with a buffer ontop using something like https://github.com/ethgasstation/ethgasstation-api ?

      Or even just plugging into Etherscan https://etherscan.io/gasTracker

      Edited by Ben Hayward 4 months ago
    • Faizan Khan
      Faizan Khan @FaizanJKhan · 4 months ago
      Reporter

      I’ve been able to comfortably use 7-15 GWEi (30-40c) which is a big improvement and still usually settles in 60-100 secs - but I definitely agree a % buffer should be used just in case of price fluctuation.

      Edited by Faizan Khan 4 months ago
    • Faizan Khan @FaizanJKhan closed 4 months ago

      closed

    • Faizan Khan @FaizanJKhan reopened 4 months ago

      reopened

    • Faizan Khan @FaizanJKhan changed due date to March 29, 2019 3 months ago

      changed due date to March 29, 2019

    • Ben Hayward @benhayward.ben added T - Feature label 3 months ago

      added T - Feature label

    • Ben Hayward @benhayward.ben added 1 - High P - Platform P - Rewards labels 3 months ago

      added 1 - High P - Platform P - Rewards labels

    • Ben Hayward
      Ben Hayward @benhayward.ben · 3 months ago
      Developer

      Escalating this to high as I had another user who was wanting to move off-chain to on-chain due to a very high default gas fee. Should also take some load off the H&S channel.

      Edited by Ben Hayward 3 months ago
    • Faizan Khan @FaizanJKhan changed due date to April 05, 2019 3 months ago

      changed due date to April 05, 2019

    • Faizan Khan @FaizanJKhan changed due date to April 11, 2019 3 months ago

      changed due date to April 11, 2019

    • Faizan Khan @FaizanJKhan closed 2 weeks ago

      closed

    • Ben Hayward @benhayward.ben reopened 2 weeks ago

      reopened

    • Brian Hatchet :speech_balloon: @brianhatchet assigned to @brianhatchet 2 weeks ago

      assigned to @brianhatchet

    • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Hipster Hedgehog 2 weeks ago

      changed milestone to %sprint: Hipster Hedgehog

    • Mark Harding
      Mark Harding @markeharding · 1 week ago
      Owner

      Discussed on rev call, metamask has pretty much fixed this with their new speed suggestions.

    • Mark Harding @markeharding closed 1 week ago

      closed

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 hour ago
      Developer

      @markeharding can this be re-opened? I don't feel MetaMask have fixed this. Their speed suggestions are still unreliable and sometimes outright insane.

      There's some options we can look into without going the whole mile: https://ethereum.stackexchange.com/questions/41408/how-can-i-set-the-gas-price-while-deploying-a-contract-with-web3-js?rq=1

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    2 Assignees
    Brian Hatchet's avatar
    Faizan Khan's avatar
    Assign to
    OnChain improvements
    Epic
    OnChain improvements
    sprint: Hipster Hedgehog
    Milestone
    sprint: Hipster Hedgehog
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    Apr 11, 2019
    Due date
    Apr 11, 2019
    4
    Labels
    P - Rewards Priority::1 - High Product::Platform Type::Feature
    Assign labels
    • View project labels
    None
    Weight
    None
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    6
    6 participants
    user avatar
    Brian Hatchet
    user avatar
    Faizan Khan
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    user avatar
    Jack Ottman
    user avatar
    Bill Ottman
    Reference: minds/engine#264