Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 149
    • Issues 149
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !260

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[InterestingIguana](bug) Fixed blog edits not saving #593

Closes #593

Issue was that the property changed was protected, and could not be accessed. Rather than reworking the scope, I thought it best to use the setter.

To test, make a blog Edit it on your newsfeed

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/blog-save-on-edit-593 origin/fix/blog-save-on-edit-593

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/blog-save-on-edit-593

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/blog-save-on-edit-593 into master
The source branch is 3 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70304038 running for fd59a5b4 on fix/blog-save-on-edit-593
          Checking approval status
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #593

          Deletes source branch

          • Discussion 3
          • Commits 2
          • Pipelines 2
          • Changes 1
          1/1 thread resolved
          • Loading...
          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 19 hours ago

            approved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 19 hours ago
            Resolved by Ben Hayward 3 minutes ago
          • Mark Harding
            Mark Harding @markeharding · 16 hours ago
            Owner

            Introduced 500 error on images and videos.

            [09-Jul-2019 21:32:18] WARNING: [pool www] child 48 said into stderr: "NOTICE: PHP message: Exception #1562707938: Error: Call to undefined method Minds\Entities\Image::setHidden() in /var/www/Minds/engine/Core/Feeds/Activity/Delegates/AttachmentPaywallDelegate.php:55"
          • Mark Harding @markeharding added MR::Requires Changes label 15 hours ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 21 minutes ago

            added 1 commit

            • fd59a5b4 - Added subtype check before setting hidden #593

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 19 minutes ago
            Developer

            Fixed @markeharding

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label and removed MR::Requires Changes label 18 minutes ago

            added MR::Awaiting Review label and removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben resolved all threads 3 minutes ago

            resolved all threads

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/engine!260