Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 62
    • Merge Requests 62
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !436

Open
Opened 20 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/InterestingIguana](feat) Show error on hashtag limit when editing post #867

Closes #867

Make a post with 5 hashtags, try to edit in a sixth.

Edited 4 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/hashtag-limit-edit-867 origin/fix/hashtag-limit-edit-867

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/hashtag-limit-edit-867

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/hashtag-limit-edit-867 into master
The source branch is 4 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70188627 passed for dde8fef4 on fix/hashtag-limit-edit-867
          Requires 2 more approvals from Devs and Deployers.
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          This is a Work in Progress

          Closes #867

          Deletes source branch

          You can merge this merge request manually using the
          • Discussion 3
          • Commits 2
          • Pipelines 2
          • Changes 6
          1/1 thread resolved
          • Loading...
          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 18 hours ago

            approved this merge request

          • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 18 hours ago

            unapproved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 18 hours ago
            Resolved by Ben Hayward 13 hours ago
          • Ben Hayward @benhayward.ben added 1 commit 13 hours ago

            added 1 commit

            • dde8fef4 - Updated hashtag error to show on editing too many hashtags

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all threads 13 hours ago

            resolved all threads

          • Ben Hayward
            Ben Hayward @benhayward.ben · 13 hours ago
            Developer

            Thanks @brianhatchet, appears I missed committing a couple of files

          • Ben Hayward @benhayward.ben changed milestone to %sprint: Interesting Iguana 12 hours ago

            changed milestone to %sprint: Interesting Iguana

          • Ben Hayward @benhayward.ben mentioned in issue #1457 12 hours ago

            mentioned in issue #1457

          • Ben Hayward
            Ben Hayward @benhayward.ben · 12 hours ago
            Developer

            Need to add remind, editing remind works fine, but the remind poster still allows you to have more than 5

          • Ben Hayward @benhayward.ben marked as a Work In Progress 4 minutes ago

            marked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 4 minutes ago

            changed the description

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          sprint: Interesting Iguana
          Milestone
          sprint: Interesting Iguana
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/front!436