Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !399

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](feat): Added in buttons for play store and ios #613

Towards closing #613 (closed) https://fix-ios-android-mobile-page-update-613.minds.io/mobile

image

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/ios-android-mobile-page-update-613 origin/fix/ios-android-mobile-page-update-613

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/ios-android-mobile-page-update-613

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/ios-android-mobile-page-update-613 into master
The source branch is 69 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68888518 passed for 3d940e0a on fix/ios-android-mobile-page-update-613
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #613 (closed)

          Deletes source branch

          • Discussion 5
          • Commits 3
          • Pipelines 1
          • Changes 4
          0/3 threads resolved
          • Loading...
          • Ben Hayward @benhayward.ben changed the description 1 week ago

            changed the description

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal started a thread on the diff 1 week ago
            src/app/modules/mobile/marketing/marketing.component.ts
            38 39 this.detectChanges();
            39 40
            40 41 this.releases = await this.service.getReleases();
            42 this.latestUrl = this.releases[0].href;
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal · 1 week ago
              Developer

              Take in account that there are Canary releases listed in the remote JSON. Sync with @msantang78 to ensure you're not offering the Canary version to people who've not opted in. Maybe it's best to .filter() the releases array before you grab the 0 index.

            • Please register or sign in to reply
          • Emiliano Balbuena
            Emiliano Balbuena @edgebal started a thread on the diff 1 week ago
            src/app/modules/mobile/marketing/marketing.component.html
            7
            8
            8 9 <div class="m-marketing--hero--inner">
            9
            10 10 <div class="m-marketing--hero--slogans">
            11
            12 11 <h2>
            13 Minds Android App
            12 Minds Mobile App
            14 13 </h2>
            15
            16 14 </div>
            17
            18 15 <div class="m-marketing--hero--actions">
            19 <i class="material-icons m-mobile__giantDroid">android</i>
            16 <div class="m-marketing--hero--logos">
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal · 1 week ago
              Developer

              Maybe we can disable the button (or hide it) until latestUrl has a value. If the user has lag (which might happen because they're on the cellphone) they will be taken to minds.com/mobile/undefined.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes label 5 days ago

            added MR::Requires Changes label

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 5 days ago
            src/app/modules/mobile/marketing/marketing.component.html
            12 Minds Mobile App
            14 13 </h2>
            15
            16 14 </div>
            17
            18 15 <div class="m-marketing--hero--actions">
            19 <i class="material-icons m-mobile__giantDroid">android</i>
            16 <div class="m-marketing--hero--logos">
            17 <img [src]="minds.cdn_assets_url + 'assets/logos/bulb.svg'">
            18 </div>
            19 <div class="mdl-card__supporting-text m-marketing--section--downloadContainer">
            20 <a href="https://geo.itunes.apple.com/us/app/minds-com/id961771928?mt=8&amp;uo=6" target="_blank">
            21 <img class="m-marketing--section--downloadButton m-marketing--section--downloadButton--ios"
            22 src="https://devimages-cdn.apple.com/app-store/marketing/guidelines/images/badge-download-on-the-app-store.svg"/>
            23 </a>
            24 <a [href]="latestUrl">
            • Mark Harding
              Mark Harding @markeharding · 5 days ago
              Owner

              Use the current android button component on the homepage etc.

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding · 5 days ago
            Owner

            I think we can improve this design wise. The SEO has a nice image which I think we should use. Also, consider moving all the app store links to the right sidebar. Mockups would be better before we hit any code.

          • Ben Hayward
            Ben Hayward @benhayward.ben · 10 minutes ago
            Developer

            Passed this over to @jotto141 for some wireframes

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Jack Ottman
          Reference: minds/front!399