Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !437

Open
Opened just now by Olivia Madrid@omadrid
  • Report abuse
Report abuse

[Sprint/InterestingIguana](chore): adjust channel sidebar UI

Made some adjustments to the buttons on the channel sidebar to accommodate incoming referrals action button. Referrals button will be added once referrals console is live.

Biggest change is moving the settings cog for other peoples channels up to where the edit pencil is on your own channel. And making it a meatball.

image

When the cog is out of the way, we have enough width so that the 'message' button label can always be visible, so never gets to this awkward place:

image

One's own channel would look something like this:

image

Someone else's would look something like this (at diff widths/badge qtys):

image image

Also tweaked some uneven spacing issues and allowed this button to expand in height to prevent overflow:

image

Only known issue is that the action tab becomes an empty box when you are on a channel that you're subscribed to and you go into mobile width territory:

image

It also fixes the visible bug at certain widths on all of the founders' channels:

image

Also changed the rewards edit icon color so it's not the only thing in the blue-grey palette:

image

Edited just now by Olivia Madrid

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b chore/ChannelButtonAdjust origin/chore/ChannelButtonAdjust

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff chore/ChannelButtonAdjust

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge chore/ChannelButtonAdjust into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #70161583 running for 1216f272 on chore/ChannelButtonAdjust
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request
          • Discussion 0
          • Commits 1
          • Pipelines 1
          • Changes 6
          • Loading...
          • Olivia Madrid @omadrid changed the description just now

            changed the description

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Olivia Madrid
          Reference: minds/front!437