Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 802
    • Issues 802
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 60
    • Merge Requests 60
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !333

Closed
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](feat): Preferred hashtag remember local storage 1302

Works fine by my testing. Removed this.lastPreferredEmission so that the system just uses localStorage to determine its value, rather than storing the last state of it when navigating away and back.

Edited 3 weeks ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git preferred-hashtag-remember-local-storage-1302
git checkout -b benhayward.ben/front-preferred-hashtag-remember-local-storage-1302 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-preferred-hashtag-remember-local-storage-1302

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:preferred-hashtag-remember-local-storage-1302 into master
  • Email patches
  • Plain diff
Pipeline #67032843 passed for b93c7317 on benhayward.ben:preferred-hashtag-remember-local-storage-1302
    Requires 2 more approvals from Devs.
    Martin Santangelo
    Martin Santangelo
    Marcelo Rivera
    Marcelo Rivera
    Brian Hatchet
    Brian Hatchet
    Mark Harding
    Mark Harding
    Emiliano Balbuena
    Emiliano Balbuena

    Closed by Ben Hayward 2 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Deletes source branch

    • Discussion 6
    • Commits 5
    • Pipelines 5
    • Changes 1
    3/3 threads resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a thread on an old version of the diff 4 weeks ago
      Resolved by Ben Hayward 3 weeks ago
    • Ben Hayward @benhayward.ben changed the description 2 times within 1 minute 3 weeks ago

      changed the description 2 times within 1 minute

    • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

      added 1 commit

      • cd760d9a - switched to Storage class

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 3 weeks ago

      resolved all discussions

    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 2 weeks ago
      Resolved by Ben Hayward 2 weeks ago
    • Emiliano Balbuena
      Emiliano Balbuena @edgebal started a thread on an old version of the diff 2 weeks ago
      Resolved by Ben Hayward 2 weeks ago
    • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

      added 1 commit

      • c25bbec5 - changed syntax

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 2 weeks ago

      resolved all discussions

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 weeks ago

      approved this merge request

    • Emiliano Balbuena @edgebal approved this merge request 2 weeks ago

      approved this merge request

    • Mark Harding
      Mark Harding @markeharding · 2 weeks ago
      Owner

      Initial state should still be preferrer toggle on. Currently its off.

    • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

      added 1 commit

      • b93c7317 - flipped logic to default to on

      Compare with previous version

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 weeks ago
      Developer

      Flipped the logic @markeharding

    • Mark Harding @markeharding added MR::Awaiting Review label 1 week ago

      added MR::Awaiting Review label

    • Ben Hayward @benhayward.ben closed 2 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Marcelo Rivera
    user avatar
    Brian Hatchet
    user avatar
    Mark Harding
    user avatar
    Emiliano Balbuena
    user avatar
    Ben Hayward
    Reference: minds/front!333