Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !427

Merged
Opened 3 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](bug) Progress bar prematurely finishes on upload end, not on request end. #1500

The issue with comments at the comment is that the XHR progress event returns 100% when the image is uploaded - this is not the end of the network request though, as there is additional server side processing done. The rationale behind doing it this way, is that the progress bar, to the average user, simply means "How long until I can hit post" - they do not care about whether the image is uploaded or not.

In addition I added if (e.lengthComputable) { which should catch some future errors.

Request to merge fix/progress-indicator-upload-1500 into master
  • Email patches
  • Plain diff
Pipeline #69900159 passed for 2120a614 on fix/progress-indicator-upload-1500
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Brian Hatchet
          Brian Hatchet

          Merged by Mark Harding 1 hour ago

          The changes were merged into master with d7f9cc7d

          The source branch has been deleted

          Closed #1500 (closed)

          Pipeline #69922354 running for d7f9cc7d on master
                • Discussion 0
                • Commits 2
                • Pipelines 2
                • Changes 1
                • Loading...
                • Ben Hayward @benhayward.ben added 1 commit 2 hours ago

                  added 1 commit

                  • 2120a614 - upload limit to 99%

                  Compare with previous version

                • Mark Harding @markeharding approved this merge request 1 hour ago

                  approved this merge request

                • Mark Harding @markeharding merged 1 hour ago

                  merged

                • Mark Harding @markeharding mentioned in commit d7f9cc7d 1 hour ago

                  mentioned in commit d7f9cc7d

                • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                Please register or sign in to reply
                Assignee
                None
                Assign to
                None
                Milestone
                None
                Assign milestone
                None
                Time tracking
                No estimate or time spent
                0
                Labels
                None
                Assign labels
                • View project labels
                Lock merge request
                Unlocked
                6
                6 participants
                user avatar
                Martin Santangelo
                user avatar
                Marcelo Rivera
                user avatar
                Emiliano Balbuena
                user avatar
                Brian Hatchet
                user avatar
                Mark Harding
                user avatar
                Ben Hayward
                Reference: minds/front!427

                Revert this merge request

                This will create a new commit in order to revert the existing changes.

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.

                Cherry-pick this merge request

                Switch branch
                Cancel
                A new branch will be created in your fork and a new merge request will be started.