Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 803
    • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1500

Closed
Open
Opened 20 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug) Comment images not posting

Summary

Although some images work, a lot of users are experiencing the comments poster, not allowing them to post. Some of these reports are manifestations of #1366, users are definitely experiencing a different bug to this.

I believe this to likely be related to state changes on the front-end.

https://www.minds.com/newsfeed/994278672455299072

Steps to reproduce

  1. Go to a comments thread
  2. Upload the below image wp9
  3. Try to post it. - See bug

(while you're here) 4. press delete on the attachment 5. try to post - you will not be able to.

Platform information

Reproduced Chromium / Manjaro

What is the current bug behavior?

The image can't be posted.

What is the expected correct behavior?

This should be seamless.

Relevant logs and/or screenshots

image

Possible fixes

As removing the image, it still cannot be posted, it feels to me like it is more likely to be a front-end state bug. No errors are outputted and the network logs seem to go through fine.

/label ~"T - Bug" ~"S - Triage:new"

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 20 hours ago by Ben Hayward

Related issues
0

    Related merge requests
    1
    • Merged 33 minutes ago
      Jul 8, 2019 3:11pm GMT+0000
      [Sprint/InterestingIguana](bug) Progress bar prematurely finishes on upload end, not on request end. #1500
      Merged 33 minutes ago
      Jul 8, 2019 3:11pm GMT+0000
      !427
    When this merge request is accepted, this issue will be closed automatically.
    • Ben Hayward @benhayward.ben added Triage::New Type::Bug (Triage) labels 20 hours ago

      added Triage::New Type::Bug (Triage) labels

    • Ben Hayward @benhayward.ben changed the description 20 hours ago

      changed the description

    • Ben Hayward @benhayward.ben added Priority::0 - Urgent Product::Comments Type::Bug labels and removed Triage::New Type::Bug (Triage) labels 20 hours ago

      added Priority::0 - Urgent Product::Comments Type::Bug labels and removed Triage::New Type::Bug (Triage) labels

    • Ben Hayward @benhayward.ben assigned to @benhayward.ben 20 hours ago

      assigned to @benhayward.ben

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Interesting Iguana 20 hours ago

      changed milestone to %sprint: Interesting Iguana

    • Ben Hayward @benhayward.ben changed weight to 3 20 hours ago

      changed weight to 3

    • Ben Hayward @benhayward.ben added Status::InProgress label 19 hours ago

      added Status::InProgress label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 19 hours ago
      Developer

      The issue here is that the loading bar is not in sync with the actual progress of the request, if you click post and wait a short while for the request to end (look in dev tools if you can), you can post it fine.

    • Ben Hayward
      Ben Hayward @benhayward.ben · 16 hours ago
      Developer

      More complicated than expected. Needed to set network speed down to 3g (slow) as otherwise the progress event only fires once, since localhost is so quick. It appears that 100% is being reported, before the XHR request is resolved.

      One possible solution is to set the loading bar to a max of 95% on the progress event, and then have it jump to 100% upon completion via onload. This would allow our server some time to finish up the rest of its processing.

    • Mark Harding @markeharding added Priority::1 - High label and removed Priority::0 - Urgent label 8 hours ago

      added Priority::1 - High label and removed Priority::0 - Urgent label

    • Mark Harding @markharding mentioned in commit c2a38f2c 8 hours ago

      mentioned in commit c2a38f2c

    • Mark Harding
      Mark Harding @markeharding · 7 hours ago
      Owner

      I don't think this is as complicated as you think. Fixed with c2a38f2c, but we can keep open to reduce the 100% width until we get the attachment guid back.

    • Mark Harding @markeharding added Priority::2 - Normal label and removed Priority::1 - High label 7 hours ago

      added Priority::2 - Normal label and removed Priority::1 - High label

    • Ben Hayward @benhayward.ben mentioned in commit 1793f0a3 2 hours ago

      mentioned in commit 1793f0a3

    • Ben Hayward @benhayward.ben mentioned in commit 0734f74b 2 hours ago

      mentioned in commit 0734f74b

    • Ben Hayward @benhayward.ben mentioned in merge request !427 (merged) 2 hours ago

      mentioned in merge request !427 (merged)

    • Mark Harding @markeharding closed via merge request !427 (merged) 33 minutes ago

      closed via merge request !427 (merged)

    • Ben Hayward @benhayward.ben mentioned in commit c6689ca3 33 minutes ago

      mentioned in commit c6689ca3

    • Mark Harding @markeharding mentioned in commit d7f9cc7d 33 minutes ago

      mentioned in commit d7f9cc7d

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Ben Hayward's avatar Ben Hayward @benhayward.ben
    Assign to
    None
    Epic
    None
    sprint: Interesting Iguana
    Milestone
    sprint: Interesting Iguana
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    4
    Labels
    Priority::2 - Normal Product::Comments Status::Review Type::Bug
    Assign labels
    • View project labels
    3
    Weight
    3
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    3
    3 participants
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    user avatar
    Mark Harding
    Reference: minds/front#1500