Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 56
    • Merge Requests 56
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !422

Open
Opened 18 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](bug): Added in bottom margin for mobile #1416

I want to test this in sandbox on browserstack across a range of devices, so keeping in WIP state for now.

Galaxy 10 / Chrome

image image

IPhone X / Safari

image image

IPhone X / Chrome

image image

IPhone 6 / Safari

image image

Pixel (8.0.0)

image image

Login Page

image

Edited 19 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/bottom-bar-margin-1416 origin/fix/bottom-bar-margin-1416

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/bottom-bar-margin-1416

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/bottom-bar-margin-1416 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69709688 running for ede062e9 on fix/bottom-bar-margin-1416
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Brian Hatchet
          Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Mentions #1416

          Deletes source branch

          • Discussion 0
          • Commits 4
          • Pipelines 3
          • Changes 3
          • Loading...
          • Ben Hayward @benhayward.ben added 2 commits 53 minutes ago

            added 2 commits

            • 400231aa - Updated to fix for android
            • 01c4e094 - removed commented out lines

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 20 minutes ago

            changed the description

          • Ben Hayward @benhayward.ben added 1 commit 19 minutes ago

            added 1 commit

            • ede062e9 - fixed login component

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 19 minutes ago

            unmarked as a Work In Progress

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/front!422