Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 58
    • Merge Requests 58
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !415

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](BUG) Fix period char username fix #1481

Closes #1481

image

Switched link output to red to ease reading:

image

Edited 1 day ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix-period-char-username-fix-1481 origin/fix-period-char-username-fix-1481

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix-period-char-username-fix-1481

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix-period-char-username-fix-1481 into master
The source branch is 9 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69583993 running for d170139f on fix-period-char-username-fix-1481
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1481

          Deletes source branch

          • Discussion 4
          • Commits 11
          • Pipelines 5
          • Changes 2
          1/2 threads resolved
          • Loading...
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Ben Hayward 1 day ago
          • Ben Hayward @benhayward.ben marked as a Work In Progress 1 day ago

            marked as a Work In Progress

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • 43a6eb04 - updated 3rd match usage in returned string

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 1 day ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 2 times within 4 minutes 1 day ago

            changed the description 2 times within 4 minutes

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • c147a939 - Added test

            Compare with previous version

          • Ben Hayward @benhayward.ben resolved all discussions 1 day ago

            resolved all discussions

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • 6adf46be - Removed focused test

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Last updated by Ben Hayward 12 minutes ago
            src/app/common/pipes/tags.spec.ts
            79 79 expect(transformedString).toContain('<a class="tag"');
            80 80 });
            81 81
            82 it('should transform when @ followed by `.com`', () => {
            83 const pipe = new TagsPipe(featuresServiceMock);
            84 const string = 'textstring @name.com';
            85 const transformedString = pipe.transform(<any>string);
            86 expect(transformedString).toContain('<a class="tag"');
            87 expect(transformedString).toContain('@name.com');
            88 });
            89
            90 it('should transform two adjacent tags', () => {
            • Mark Harding
              Mark Harding @markeharding · 1 day ago
              Owner

              I think this test still needs more. Production bug had 12 tags in.

            • Ben Hayward
              Ben Hayward @benhayward.ben · 12 minutes ago
              Developer

              No problem, I'll update now

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes label 4 hours ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 14 minutes ago

            added 1 commit

            • d170139f - added check for multiple tags adjacent

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review label and removed MR::Requires Changes label 12 minutes ago

            added MR::Awaiting Review label and removed MR::Requires Changes label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          Reference: minds/front!415