Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 58
    • Merge Requests 58
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !400

Closed
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog](bug): Fix mobile group chat disapearing on keyboard #1416

Closes #1416

I've hit my head off this one for a while but the only way I could find to do it, leaves a bit more of a gap than I would like on some tested phones (see s7 edge)

S7 edge Brave:

(this is through chrome report so note that the keyboard area just appears as white)

image image

iPhone 8 Safari

image

Pixel XL Firefox

image

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/groups-chat-conversation-textbox-fixes-1416 origin/fix/groups-chat-conversation-textbox-fixes-1416

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/groups-chat-conversation-textbox-fixes-1416

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/groups-chat-conversation-textbox-fixes-1416 into master
  • Email patches
  • Plain diff
Pipeline #68891518 failed for bb7728c7 on fix/groups-chat-conversation-textbox-fixes-1416
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding

          Closed by Ben Hayward 2 minutes ago

          The changes were not merged into master

          Did not close #1416

          Deletes source branch

          • Discussion 1
          • Commits 5
          • Pipelines 1
          • Changes 1
          • Loading...
          • Mark Harding
            Mark Harding @markeharding · 3 days ago
            Owner

            There is a larger issue here. We shouldn't need to be hacking away at all of our containers just because we have a bottom bar on mobile. Lets try putting the bottom bar below the topbar.

          • Mark Harding @markeharding added MR::Requires Changes label 1 day ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added Status::Backlog label and removed MR::Requires Changes label 2 minutes ago

            added Status::Backlog label and removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben closed 2 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          Status::Backlog
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          Reference: minds/front!400