Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 136
    • Issues 136
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !251

Open
Opened 22 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): Offchain boost rate limiting #475

Closes #475

May need to distribute off-chain tokens for staging, using the php-cli. php cli.php rewards issue --username=nemofin --amount=10000

image

Edited 27 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/rate-limit-boost-475 origin/feat/rate-limit-boost-475

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/rate-limit-boost-475

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/rate-limit-boost-475 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69485172 passed for 3817cb1f on feat/rate-limit-boost-475
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #475

          Deletes source branch

          • Discussion 5
          • Commits 5
          • Pipelines 5
          • Changes 5
          2/2 discussions resolved
          • Loading...
          • Ben Hayward
            Ben Hayward @benhayward.ben · 22 hours ago
            Developer

            Need to do some testing, and run this by somebody. Not 100% sure I've properly filtered down the transactions as the number coming out is not quite what I'd expect (though is close). Could be related to ES running under low disk constraints.

          • Mark Harding
            Mark Harding @markeharding started a discussion on an old version of the diff 14 hours ago
            Resolved by Ben Hayward 26 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a discussion on an old version of the diff 14 hours ago
            Resolved by Ben Hayward 25 minutes ago
          • Mark Harding @markeharding added MR::Requires Changes label 14 hours ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 2 commits 1 hour ago

            added 2 commits

            • 6015b386 - Added in rate limits for offchain boosts.
            • ad1bd20f - Updates, refactor and added tests

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 34 minutes ago

            added 1 commit

            • 21f43ead - Updated, added in reduce for counting impressions and extra test

            Compare with previous version

          • Ben Hayward @benhayward.ben added 2 commits 30 minutes ago

            added 2 commits

            • 1e8d36d4 - spacing
            • 3817cb1f - syntax

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 27 minutes ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 27 minutes ago

            changed the description

          • Ben Hayward @benhayward.ben resolved all discussions 26 minutes ago

            resolved all discussions

          • Ben Hayward @benhayward.ben resolved all discussions 25 minutes ago

            resolved all discussions

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Ben Hayward
          Reference: minds/engine!251