Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 135
    • Issues 135
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !250

Open
Opened 16 hours ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

(feat): Retry queue for ElasticSearch

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b sprint/ii.es-retry-580 origin/sprint/ii.es-retry-580

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff sprint/ii.es-retry-580

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge sprint/ii.es-retry-580 into master
The source branch is 5 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69287863 passed for 7d856c7e on sprint/ii.es-retry-580
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Ben Hayward
          Ben Hayward
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Deletes source branch

          • Discussion 6
          • Commits 2
          • Pipelines 2
          • Changes 7
          2/3 discussions resolved
          • Loading...
          • Emiliano Balbuena @edgebal mentioned in merge request !249 (closed) 16 hours ago

            mentioned in merge request !249 (closed)

          • Emiliano Balbuena @edgebal added 1 commit 16 hours ago

            added 1 commit

            • 7d856c7e - (fix): Bad CQL; (chore): Style and logging

            Compare with previous version

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff 15 hours ago
            Resolved by Emiliano Balbuena 2 minutes ago
          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff 15 hours ago
            Resolved by Emiliano Balbuena 1 minute ago
          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff 15 hours ago
            Last updated by Mark Harding 4 hours ago
            Core/Search/Events.php
            11 11
            12 12 class Events
            13 13 {
            14 /** @var Delegates\DispatchIndexDelegate */
            15 protected $dispatchIndexDelegate;
            16
            17 /**
            18 * Events constructor.
            19 * @param Delegates\DispatchIndexDelegate $dispatchIndexDelegate
            20 */
            21 public function __construct(
            22 $dispatchIndexDelegate = null
            23 )
            24 {
            25 $this->dispatchIndexDelegate = $dispatchIndexDelegate ?: new Delegates\DispatchIndexDelegate();
            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 15 hours ago
              Maintainer

              Feels like Delegate should be a manager if we're using it directly inside the events

            • Mark Harding
              Mark Harding @markeharding · 4 hours ago
              Owner

              Agree with @brianhatchet

            Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes label 4 hours ago

            added MR::Requires Changes label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          Reference: minds/engine!250