(feat): Retry queue for ElasticSearch
0/3 discussions resolved
mentioned in merge request !249 (closed)
1414 1414 hidden_since timestamp, 1415 1415 PRIMARY KEY (hashtag) 1416 1416 ); 1417 1418 CREATE TABLE minds.search_dispatcher_queue ( 1419 entity_urn text, 1420 last_retry timestamp, - Maintainer
<3
27 28 /** 29 * DispatchIndexDelegate constructor. 30 * @param EventsDispatcher $eventsDispatcher 31 * @param SearchIndex $searchIndex 32 * @param RetryQueueRepository $retryQueue 33 */ 34 public function __construct( 35 $eventsDispatcher = null, 36 $searchIndex = null, 37 $retryQueue = null 38 ) 39 { 40 $this->eventsDispatcher = $eventsDispatcher ?: Di::_()->get('EventsDispatcher'); 41 $this->searchIndex = $searchIndex ?: Di::_()->get('Search\Index'); 42 $this->retryQueueRepository = $retryQueue ?: new RetryQueueRepository(); - Maintainer
Shouldn't this repository be injected?
11 11 12 12 class Events 13 13 { 14 /** @var Delegates\DispatchIndexDelegate */ 15 protected $dispatchIndexDelegate; 16 17 /** 18 * Events constructor. 19 * @param Delegates\DispatchIndexDelegate $dispatchIndexDelegate 20 */ 21 public function __construct( 22 $dispatchIndexDelegate = null 23 ) 24 { 25 $this->dispatchIndexDelegate = $dispatchIndexDelegate ?: new Delegates\DispatchIndexDelegate(); - Maintainer
Feels like Delegate should be a manager if we're using it directly inside the events