Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 793
    • Issues 793
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 59
    • Merge Requests 59
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !415

Open
Opened 16 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](BUG) Fix period char username fix #1481

Closes #1481

image

Switched link output to red to ease reading:

image

Edited 6 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix-period-char-username-fix-1481 origin/fix-period-char-username-fix-1481

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix-period-char-username-fix-1481

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix-period-char-username-fix-1481 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69285546 canceled for 43a6eb04 on fix-period-char-username-fix-1481
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1481

          Deletes source branch

          • Discussion 1
          • Commits 8
          • Pipelines 2
          • Changes 2
          0/1 discussion resolved
          • Loading...
          • Mark Harding
            Mark Harding @markeharding started a discussion on the diff 12 minutes ago
            src/app/common/pipes/tags.spec.ts
            79 79 expect(transformedString).toContain('<a class="tag"');
            80 80 });
            81 81
            82 it('should transform when @ followed by `.com`', () => {
            • Mark Harding
              Mark Harding @markeharding · 12 minutes ago
              Owner

              We need a test to cover the production bug that caused the rollback

            Please register or sign in to reply
          • Ben Hayward @benhayward.ben marked as a Work In Progress 9 minutes ago

            marked as a Work In Progress

          • Ben Hayward @benhayward.ben added 1 commit 7 minutes ago

            added 1 commit

            • 43a6eb04 - updated 3rd match usage in returned string

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 6 minutes ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 2 times within 4 minutes 6 minutes ago

            changed the description 2 times within 4 minutes

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/front!415