Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 793
    • Issues 793
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 59
    • Merge Requests 59
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !405

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

Boost button mobile offscreen #1357

Closes #1357

Screenshot_20190703-204252_Brave

Screenshot_20190703-204316_BraveCloses #1357

image

Edited 15 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/mob-boost-btn-offscreen-1357 origin/fix/mob-boost-btn-offscreen-1357

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/mob-boost-btn-offscreen-1357

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/mob-boost-btn-offscreen-1357 into master
The source branch is 26 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69282743 running for b0e70291 on fix/mob-boost-btn-offscreen-1357
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1357

          Deletes source branch

          • Discussion 2
          • Commits 3
          • Pipelines 5
          • Changes 2
          • Loading...
          • Mark Harding
            Mark Harding @markeharding · 1 day ago
            Owner

            Screen_Shot_2019-07-02_at_8.53.14_PM

          • Mark Harding @markeharding added MR::Requires Changes label 1 day ago

            added MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 22 hours ago

            added 1 commit

            • d795e9b4 - Added in poiner on a-links in group chat

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 42 minutes ago

            added 1 commit

            • f6437d8c - updated to work on smaller devices

            Compare with previous version

          • Ben Hayward @benhayward.ben added 2 commits 19 minutes ago

            added 2 commits

            • 61383a5c - added missing changes
            • b0e70291 - Added missing changes

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 15 minutes ago

            changed the description

          • Ben Hayward
            Ben Hayward @benhayward.ben · 12 minutes ago
            Developer

            Took more away to support smaller phones.

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Requires Changes
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/front!405