Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 134
    • Issues 134
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !240

Merged
Opened 1 day ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): added gif flag to activities

closes #544 (closed)

@markeharding , this is needed by mobile-native!239 (merged)

Request to merge feat/add-gif-flag-to-activities into master
  • Email patches
  • Plain diff
Pipeline #68856602 passed for 41b2fd3d on feat/add-gif-flag-to-activities
          Merge request approved. Approved by
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward
          Martin Santangelo
          Martin Santangelo

          Merged by Mark Harding 26 minutes ago

          The changes were merged into master with 7aa33c33

          The source branch has been deleted

          Closed #544 (closed)

          Pipeline #69241478 running for 7aa33c33 on master
                  • Discussion 3
                  • Commits 2
                  • Pipelines 1
                  • Changes 1
                  • Loading...
                  • Marcelo Rivera @eiennohi mentioned in merge request !223 (closed) 1 day ago

                    mentioned in merge request !223 (closed)

                  • Mark Harding
                    Mark Harding @markeharding · 22 hours ago
                    Owner

                    @eiennohi What happens if the gif flag is not for legacy posts?

                    cc/ @msantang78 @juanmsolaro

                  • Juan Manuel Solaro
                    Juan Manuel Solaro @juanmsolaro · 20 hours ago
                    Developer

                    if the gif flag is missing the media will be downloaded as a 'jpg', just like before. Screenshot_from_2019-07-02_16-05-47

                  • Mark Harding @markeharding approved this merge request 19 hours ago

                    approved this merge request

                  • Mark Harding
                    Mark Harding @markeharding · 19 hours ago
                    Owner

                    not a gif: https://feat-add-gif-flag-to-activities.minds.io/newsfeed/992876928295768081 gif: https://feat-add-gif-flag-to-activities.minds.io/newsfeed/992876334491373585

                    confirmed tags apply. need another approval.

                  • Emiliano Balbuena @edgebal approved this merge request 2 hours ago

                    approved this merge request

                  • Mark Harding @markeharding mentioned in commit 7aa33c33 26 minutes ago

                    mentioned in commit 7aa33c33

                  • Mark Harding @markeharding merged 26 minutes ago

                    merged

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  Assignee
                  None
                  Assign to
                  None
                  Milestone
                  None
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  0
                  Labels
                  None
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  8
                  8 participants
                  user avatar
                  Brian Hatchet
                  user avatar
                  Rami Albatal
                  user avatar
                  Ben Hayward
                  user avatar
                  Martin Santangelo
                  user avatar
                  Mark Harding
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Juan Manuel Solaro
                  Reference: minds/engine!240

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.