Skip to content

Minds Frontend
Minds Frontend
Closed
Opened by Ben Hayward@benhayward.ben
Report abuse

[Sprint/AspiringAlbatros](feat): Split off badges into a separate component

Closing #1086 (closed)

The idea here was to build a container class around the existing badges component, so that additional badges can be appended without having side-effects on the original badges component's usage next to a users name in a comment.

This is intended to provide a clearer scaffolding for the addition of future badges.

  • All badges - hardcoded at the end of the load fn for testing (this also shows them in the newsfeed): image

  • Actual badges on that test account: image

  • Narrowest phone ever created:

image

Note, the badges show as black. This has always been the case for myself locally, but this should not be the case live. From my tests, I also do not believe that this has an effect on the use of badges next to a username in the newsfeed or comments, as in those instances the badge names applicable are passed in through "badges".

Edited by Ben Hayward
Request to merge benhayward.ben:badges-split-component-sidebar into master
Pipeline #57332042 passed for bf76ee50 on benhayward.ben:badges-split-component-sidebar
    Requires approval.

    Closed by Mark Harding

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #1086 (closed)

    Deletes source branch

    0/1 discussion resolved
    Please register or sign in to reply