Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 815
    • Issues 815
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 67
    • Merge Requests 67
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !394

Open
Opened 1 day ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): ability to copy and paste images into posts and comments

closes minds#553

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/copy-and-paste-images-in-posts origin/feat/copy-and-paste-images-in-posts

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/copy-and-paste-images-in-posts

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/copy-and-paste-images-in-posts into master
The source branch is 13 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68856957 failed for 18d4f68c on feat/copy-and-paste-images-in-posts
          Requires 2 more approvals from Devs and Deployers.
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes minds#553

          Deletes source branch

          • Discussion 3
          • Commits 4
          • Pipelines 1
          • Changes 12
          0/1 discussion resolved
          • Loading...
          • Marcelo Rivera @eiennohi mentioned in merge request !374 (closed) 1 day ago

            mentioned in merge request !374 (closed)

          • Mark Harding
            Mark Harding @markeharding started a discussion on the diff 59 minutes ago
            src/app/common/components/editors/textarea.component.ts
            62 66 }
            63 67
            64 68 paste(e: any) {
            65 e.preventDefault();
            69 // e.preventDefault();
            • Mark Harding
              Mark Harding @markeharding · 59 minutes ago
              Owner

              Can we double check why we had this originally?

            Please register or sign in to reply
          • Mark Harding @markeharding added MR::Awaiting Review label 58 minutes ago

            added MR::Awaiting Review label

          • Mark Harding
            Mark Harding @markeharding · 51 minutes ago
            Owner

            Confirmed this works. However, my copied gif no longer animates with copy/paste flow?

          • Mark Harding
            Mark Harding @markeharding · 51 minutes ago
            Owner

            Also confirm !394 (diffs, comment 187720495) and then we are good

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Ben Hayward
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          Reference: minds/front!394