Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !245

Open
Opened 29 minutes ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

WIP: (refactor): Deprecate CockroachDB

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b hotfix/cdb-deprec-569 origin/hotfix/cdb-deprec-569

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff hotfix/cdb-deprec-569

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge hotfix/cdb-deprec-569 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69084682 failed for 88ae52a4 on hotfix/cdb-deprec-569
          Requires 2 more approvals from Devs and Deployers.
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding
          This is a Work in Progress

          Deletes source branch

          You can merge this merge request manually using the
          • Discussion 2
          • Commits 2
          • Pipelines 1
          • Changes 12
          0/2 discussions resolved
          • Loading...
          • Mark Harding
            Mark Harding @markeharding started a discussion on the diff 27 minutes ago
            Core/Provisioner/Provisioners/cassandra-provision.cql
            1409 );
            1410
            1411 CREATE TABLE minds.hidden_hashtags (
            1412 hashtag text,
            1413 admin_guid varint,
            1414 hidden_since timestamp,
            1415 PRIMARY KEY (hashtag)
            1416 );
            1417
            1418 CREATE TABLE minds.entity_hashtags (
            • Mark Harding
              Mark Harding @markeharding · 27 minutes ago
              Owner

              pretty sure we do not need

            Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a discussion on the diff 26 minutes ago
            Core/Hashtags/Entity/Repository.php
            28 38 throw new \Exception('entity_guid must be provided');
            29 39 }
            30 40
            31 $query = "SELECT * FROM entity_hashtags WHERE guid=?";
            32 $params = [$opts['entity_guid']];
            41 $cql = "SELECT * FROM entity_hashtags WHERE guid = ?";
            • Mark Harding
              Mark Harding @markeharding · 26 minutes ago
              Owner

              Should we return an empty response?

            Please register or sign in to reply
          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          Reference: minds/engine!245