Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !240

Open
Opened 1 day ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): added gif flag to activities

closes #544

@markeharding , this is needed by mobile-native!239 (merged)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/add-gif-flag-to-activities origin/feat/add-gif-flag-to-activities

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/add-gif-flag-to-activities

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/add-gif-flag-to-activities into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68856602 passed for 41b2fd3d on feat/add-gif-flag-to-activities
          Requires 2 more approvals from Devs.
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #544

          Deletes source branch

          • Discussion 2
          • Commits 2
          • Pipelines 1
          • Changes 1
          • Loading...
          • Marcelo Rivera @eiennohi mentioned in merge request !223 (closed) 1 day ago

            mentioned in merge request !223 (closed)

          • Mark Harding
            Mark Harding @markeharding · 2 hours ago
            Owner

            @eiennohi What happens if the gif flag is not for legacy posts?

            cc/ @msantang78 @juanmsolaro

          • Juan Manuel Solaro
            Juan Manuel Solaro @juanmsolaro · 23 minutes ago
            Developer

            if the gif flag is missing the media will be downloaded as a 'jpg', just like before. Screenshot_from_2019-07-02_16-05-47

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Ben Hayward
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Juan Manuel Solaro
          Reference: minds/engine!240