Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !242

Open
Opened 23 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog](bug): Fix/imagick upgrade migration

Closes #563 (needed to make an issue for the branch naming constraint)

Had to fix the issues I was having locally with Imagick to enable progress on other tasks that were reliant on this. With the help of @brianhatchet I have identified that the version installed is Imagick 3.4.0. Since Imagick 3.2.0 flattenImages() has been depreciated, I have replaced this with its recommended counterpart.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/imagick-upgrade-migration-563 origin/fix/imagick-upgrade-migration-563

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/imagick-upgrade-migration-563

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/imagick-upgrade-migration-563 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #69060603 passed for 8bcae42b on fix/imagick-upgrade-migration-563
          Requires 2 more approvals from Devs.
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #563

          Deletes source branch

          • Discussion 1
          • Commits 2
          • Pipelines 2
          • Changes 2
          • Loading...
          • Ben Hayward @benhayward.ben changed milestone to %sprint: Hipster Hedgehog 23 hours ago

            changed milestone to %sprint: Hipster Hedgehog

          • Mark Harding
            Mark Harding @markeharding · 3 hours ago
            Owner

            ensure you are up to date with master here so that the subdomain will deploy

          • Ben Hayward @benhayward.ben added 7 commits 14 minutes ago

            added 7 commits

            • f9321cbd...da07df74 - 6 commits from branch master
            • 8bcae42b - Merge branch 'master' of gitlab.com:minds/engine into fix/imagick-upgrade-migration-563

            Compare with previous version

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          sprint: Hipster Hedgehog
          Milestone
          sprint: Hipster Hedgehog
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/engine!242