Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 816
    • Issues 816
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 69
    • Merge Requests 69
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !363

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](feat): For mobile page SEO

Accompanies engine!203 (diffs)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git add-photo-for-mobile-seo
git checkout -b benhayward.ben/front-add-photo-for-mobile-seo FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-add-photo-for-mobile-seo

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:add-photo-for-mobile-seo into master
  • Email patches
  • Plain diff
Pipeline #67034921 passed for 0c2f4780 on benhayward.ben:add-photo-for-mobile-seo
    Merge request approved. Approved by
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Marcelo Rivera
    Marcelo Rivera

    Merged by Mark Harding 10 minutes ago

    The changes were merged into master with 025d2eb9

    Pipeline #69016698 pending for 025d2eb9 on master
          • Discussion 2
          • Commits 2
          • Pipelines 2
          • Changes 1
          • Loading...
          • Mark Harding
            Mark Harding @markeharding · 1 week ago
            Owner

            Png's are too large, we should used compressed jpegs

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • 0c2f4780 - Switching to jpeg

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 week ago
            Developer

            resolved @markeharding

          • Mark Harding @markeharding approved this merge request 1 week ago

            approved this merge request

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

            approved this merge request

          • Ben Hayward @benhayward.ben mentioned in merge request engine!203 1 week ago

            mentioned in merge request engine!203

          • Emiliano Balbuena @edgebal approved this merge request 1 week ago

            approved this merge request

          • Mark Harding @markeharding added MR::Awaiting Review label 1 day ago

            added MR::Awaiting Review label

          • Mark Harding @markeharding merged 10 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit 025d2eb9 10 minutes ago

            mentioned in commit 025d2eb9

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Marcelo Rivera
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Ben Hayward
          user avatar
          Brian Hatchet
          Reference: minds/front!363

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.