Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 816
    • Issues 816
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 69
    • Merge Requests 69
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !376

Closed
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog](bug) Updated tags pipe to allow . character mid tag #89

Closes #89 (closed)

Many thanks to @edgebal for helping me get it to take into consideration a space after the period character.

image image

Edited 6 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git period-char-username-cutoff-tag-fix
git checkout -b benhayward.ben/front-period-char-username-cutoff-tag-fix FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-period-char-username-cutoff-tag-fix

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:period-char-username-cutoff-tag-fix into master
  • Email patches
  • Plain diff
Pipeline #67949360 passed for cee746c8 on benhayward.ben:period-char-username-cutoff-tag-fix
    Requires approval from Devs. Approved by
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Marcelo Rivera
    Marcelo Rivera
    Mark Harding
    Mark Harding

    Closed by Ben Hayward 13 hours ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #89 (closed)

    Deletes source branch

    • Discussion 3
    • Commits 4
    • Pipelines 5
    • Changes 2
    1/1 discussion resolved
    • Loading...
    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

      approved this merge request

    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • 1dbbf3d0 - Update tags.spec.ts

      Compare with previous version

    • Ben Hayward
      Ben Hayward @benhayward.ben · 6 days ago
      Developer

      I've been thinking about this and is this what we want to do @edgebal. take for example there, i tagged you at the end of the sentence and there is a full stop. Will this change not mess up a lot of existing tags on the site?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 6 days ago
      Developer

      Maybe we should only do this if the dot is not followed by a space?

    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • b445b988 - Update tags.ts

      Compare with previous version

    • Ben Hayward @benhayward.ben added 2 commits 6 days ago

      added 2 commits

      • 5523371d - Updated regex
      • 7fe81df8 - removed fdesc

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 6 days ago

      changed the description

    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff 6 days ago
      Resolved by Ben Hayward 6 days ago
    • Emiliano Balbuena @edgebal approved this merge request 6 days ago

      approved this merge request

    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • cee746c8 - fix to regex

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 6 days ago

      changed the description

    • Ben Hayward @benhayward.ben resolved all discussions 6 days ago

      resolved all discussions

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

      approved this merge request

    • Mark Harding @markeharding added MR::Awaiting Review label 1 day ago

      added MR::Awaiting Review label

    • Ben Hayward @benhayward.ben closed 13 hours ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/front!376