Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 71
    • Merge Requests 71
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !357

Closed
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](feat): Added in buttons for play store and ios #613

Towards closing #613

image

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git ios-android-added-play-store2
git checkout -b benhayward.ben/front-ios-android-added-play-store2 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-ios-android-added-play-store2

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:ios-android-added-play-store2 into master
  • Email patches
  • Plain diff
Pipeline #67067900 passed for 28c37730 on benhayward.ben:ios-android-added-play-store2
    Requires approval from Devs. Approved by
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Marcelo Rivera
    Marcelo Rivera
    Mark Harding
    Mark Harding

    Closed by Ben Hayward 10 hours ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #613

    Deletes source branch

    • Discussion 5
    • Commits 2
    • Pipelines 2
    • Changes 4
    1/1 discussion resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
      Resolved by Ben Hayward 3 days ago
    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • 28c37730 - Addressed feedback

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

      approved this merge request

    • Ben Hayward @benhayward.ben mentioned in issue #1331 4 days ago

      mentioned in issue #1331

    • Luculent
      Luculent @luculent · 4 days ago

      This is great :)

      However, it still requires a user to find that very tiny download link tucked away in the most innocuous place on the entire site.

      Placing the android download link in the hamburg menu is imperative.

    • Ben Hayward @benhayward.ben resolved all discussions 3 days ago

      resolved all discussions

    • Mark Edworthy
      Mark Edworthy @medworthy · 3 days ago

      Remember that considering the current situation, it would be sensible to promote the unfettered APK (that is hosted within Minds infrastructure) whenever possible.

      Considering the political situation (both on-site and further afield), it must be considered as an imperative to promote the unfettered APK over the Google Playstore version.

    • Mark Edworthy
      Mark Edworthy @medworthy · 3 days ago

      I also suggest adding a disclaimer to the /mobile page which provides an explanation about the limitations of the mobile applications.

      It might be a good idea to add a statement within the corresponding iOS and Android store pages which provides limited information about the issue with an inclusion of a link to the minds.com domain, and (maybe) further promoting the browser interface (this means that rather then directly promoting the unfettered APK, the store pages are only referencing the minds.com and therefore not in direct violation of any 3rd party store contractual agreements).

    • Mark Harding @markeharding added MR::Awaiting Review label 22 hours ago

      added MR::Awaiting Review label

    • Ben Hayward @benhayward.ben closed 10 hours ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    8
    8 participants
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Mark Edworthy
    user avatar
    Luculent
    Reference: minds/front!357