Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 71
    • Merge Requests 71
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !381

Closed
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog](bug): Fix mobile group chat disapearing on keyboard #1416

Closes #1416

I've hit my head off this one for a while but the only way I could find to do it, leaves a bit more of a gap than I would like on some tested phones (see s7 edge)

S7 edge Brave:

(this is through chrome report so note that the keyboard area just appears as white)

image image

iPhone 8 Safari

image

Pixel XL Firefox

image

Edited 26 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git groups-chat-conversation-textbox-fix
git checkout -b benhayward.ben/front-groups-chat-conversation-textbox-fix FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-groups-chat-conversation-textbox-fix

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:groups-chat-conversation-textbox-fix into master
  • Email patches
  • Plain diff
Pipeline #68207872 passed for e1b46681 on benhayward.ben:groups-chat-conversation-textbox-fix
    Requires approval from Devs. Approved by
    Brian Hatchet
    Brian Hatchet
    Marcelo Rivera
    Marcelo Rivera
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo

    Closed by Ben Hayward 26 minutes ago

    The changes were not merged into master

    Did not close #1416

    • Discussion 0
    • Commits 4
    • Pipelines 5
    • Changes 1
    • Loading...
    • Ben Hayward @benhayward.ben added 1 commit 5 days ago

      added 1 commit

      • 660df89d - Bad commit

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 5 days ago

      added 1 commit

      • eb3743a6 - formatting

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 5 days ago

      added 1 commit

      • e1b46681 - accidental development artifact

      Compare with previous version

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

      approved this merge request

    • Mark Harding @markeharding added MR::Awaiting Review label 12 hours ago

      added MR::Awaiting Review label

    • Ben Hayward @benhayward.ben changed the description 26 minutes ago

      changed the description

    • Ben Hayward @benhayward.ben closed 26 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Martin Santangelo
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/front!381