Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 71
    • Merge Requests 71
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !243

Closed
Opened 2 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/Zero](bug): Duplicate message bug fix

Closing #380 (closed)

Firstly I've mapped the this.messages array over to an array containing just the GUIDs, then I check whether the length of the GUID array is greater than 0, and there is more than one message incoming.

If that is the case then I filter out all entries in response.messages that have a matching entry inside of the keys array. (As they are duplicated).

Spent a while testing this, as it's an important one. I've tested between different accounts and in different situations (e.g. already have a large amount of messages, first time messaging etc).

Edited 2 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git duplicate-message-bug-fix03
git checkout -b benhayward.ben/front-duplicate-message-bug-fix03 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-duplicate-message-bug-fix03

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:duplicate-message-bug-fix03 into master
  • Email patches
  • Plain diff
Pipeline #56105999 passed for a08d22aa on benhayward.ben:duplicate-message-bug-fix03
    Requires approval.

    Closed by Ben Hayward 1 hour ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #380 (closed)

    Deletes source branch

    • Discussion 2
    • Commits 3
    • Pipelines 3
    • Changes 1
    1/1 discussion resolved
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 2 months ago

      changed the description

    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 2 months ago
      Resolved by Ben Hayward 2 months ago
    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • a08d22aa - Update conversation.component.ts

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 2 months ago

      resolved all discussions

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      Something else seems to be going.

    • Mark Harding @markeharding added MR::Awaiting Review label 12 hours ago

      added MR::Awaiting Review label

    • Ben Hayward @benhayward.ben closed 1 hour ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    Reference: minds/front!243