Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 72
    • Merge Requests 72
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !384

Closed
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/HipsterHedgehog](feat): Added confirm dialog to blogs edit

-subdomain=pinwheel

Edited 1 day ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b confirm-leave-dialog-blogs origin/confirm-leave-dialog-blogs

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff confirm-leave-dialog-blogs

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge confirm-leave-dialog-blogs into master
  • Email patches
  • Plain diff
Pipeline #68659372 canceled for e4a5fd76 on confirm-leave-dialog-blogs
          Requires 2 more approvals from Devs and Deployers.
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo

          Closed by Ben Hayward 34 minutes ago

          The changes were not merged into master

          Deletes source branch

          • Discussion 2
          • Commits 1
          • Pipelines 1
          • Changes 2
          • Loading...
          • Mark Harding
            Mark Harding @markeharding · 1 day ago
            Owner

            Doesn't appear to be working from my tests on pinwheel.minds.io.

          • Ben Hayward @benhayward.ben marked as a Work In Progress 1 day ago

            marked as a Work In Progress

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 day ago
            Developer

            Hmm, perhaps the this.editing isn't being set correctly. I will investigate and bring down the subdomain.

            Got some weird goings on with Imagick again after nuking everything and going for a fresh install of the full stack, so I can't set an avatar, and by extension can't post a blog. Was going to drop a message to the team on Monday to ask for any suggestions.

          • Mark Harding @markeharding added MR::Awaiting Review label 11 hours ago

            added MR::Awaiting Review label

          • Ben Hayward @benhayward.ben closed 34 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          MR::Awaiting Review
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/front!384