Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 159
    • Issues 159
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !222

Closed
Opened 1 week ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (fix): when deleting activity, also remove from moderated group queue

closes #504

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/engine.git sprint/HipsterHedgehog.fix.deleting-post-doesnt-delete-it-from-moderated-group-queue
git checkout -b eiennohi/engine-sprint/HipsterHedgehog.fix.deleting-post-doesnt-delete-it-from-moderated-group-queue FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/engine-sprint/HipsterHedgehog.fix.deleting-post-doesnt-delete-it-from-moderated-group-queue

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/HipsterHedgehog.fix.deleting-post-doesnt-delete-it-from-moderated-group-queue into master
  • Email patches
  • Plain diff
Pipeline #67733126 passed for 358abfcf on eiennohi:sprint/HipsterHedgehog.fix.deleting-post-doesnt-delete-it-from-moderated-group-queue
      Requires approval from Devs. Approved by
      Brian Hatchet
      Brian Hatchet
      Rami Albatal
      Rami Albatal
      Emiliano Balbuena
      Emiliano Balbuena
      Ben Hayward
      Ben Hayward
      Mark Harding
      Mark Harding
      Martin Santangelo
      Martin Santangelo

      Closed by Marcelo Rivera 16 minutes ago

      The changes were not merged into master

      Allows commits from members who can merge to the target branch

      Did not close #504

      Deletes source branch

      • Discussion 1
      • Commits 1
      • Pipelines 3
      • Changes 1
      • Loading...
      • Marcelo Rivera @eiennohi added 1 commit 1 week ago

        added 1 commit

        • 7d9d96bc - (feat): added gif flag to activities custom_data array

        Compare with previous version

      • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

        approved this merge request

      • Mark Harding @markeharding added MR::Awaiting Review label 7 hours ago

        added MR::Awaiting Review label

      • Marcelo Rivera
        Marcelo Rivera @eiennohi · 16 minutes ago
        Developer

        closing in favour of !241

      • Marcelo Rivera @eiennohi closed 16 minutes ago

        closed

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      1
      Labels
      MR::Awaiting Review
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Rami Albatal
      user avatar
      Emiliano Balbuena
      user avatar
      Ben Hayward
      user avatar
      Mark Harding
      user avatar
      Martin Santangelo
      user avatar
      Marcelo Rivera
      user avatar
      Brian Hatchet
      Reference: minds/engine!222