Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 73
    • Merge Requests 73
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !377

Closed
Opened 1 week ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (feat): image and video cards should open links in new tab in juryduty

closes #1427

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/HipsterHedgehog.feat.image-and-video-media-cards-should-open-in-new-window-for-jury-duty
git checkout -b eiennohi/front-sprint/HipsterHedgehog.feat.image-and-video-media-cards-should-open-in-new-window-for-jury-duty FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/HipsterHedgehog.feat.image-and-video-media-cards-should-open-in-new-window-for-jury-duty

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/HipsterHedgehog.feat.image-and-video-media-cards-should-open-in-new-window-for-jury-duty into master
  • Email patches
  • Plain diff
Pipeline #67773219 passed for 36c185bd on eiennohi:sprint/HipsterHedgehog.feat.image-and-video-media-cards-should-open-in-new-window-for-jury-duty
    Requires approval from Devs. Approved by
    Brian Hatchet
    Brian Hatchet
    Emiliano Balbuena
    Emiliano Balbuena
    Ben Hayward
    Ben Hayward
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo

    Closed by Marcelo Rivera 13 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #1427

    Deletes source branch

    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 7
    • Loading...
    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 6 days ago

      approved this merge request

    • Mark Harding @markeharding added MR::Awaiting Review label 7 hours ago

      added MR::Awaiting Review label

    • Marcelo Rivera @eiennohi mentioned in merge request !392 13 minutes ago

      mentioned in merge request !392

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 13 minutes ago
      Developer

      closing in favour of !392

    • Marcelo Rivera @eiennohi closed 13 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    1
    Labels
    MR::Awaiting Review
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    user avatar
    Martin Santangelo
    user avatar
    Marcelo Rivera
    user avatar
    Brian Hatchet
    Reference: minds/front!377