WIP: (feat): Boost Campaigns module
3/4 discussions resolved
added 1 commit
- ad87348f - (proto): Create campaign normalization and validation
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
- Last updated by Emiliano Balbuena
118 throw new CampaignException('Campaign should have a budget'); 119 } 120 121 // TODO: Validate offchain balance, or set as pending for onchain 122 123 // Generate URN 124 125 $guid = $this->guid->build(); 126 $urn = "urn:campaign:{$guid}"; 127 128 $campaign 129 ->setUrn($urn); 130 131 // Normalize and validate entity URNs 132 133 $entityUrns = array_values(array_unique(array_filter(Text::buildArray($campaign->getEntityUrns())))); - Owner
not sure what we can do here to avoid function overload changed this line in version 3 of the diff
- Developer
Awful, eh? I was thinking on creating a
Collection
class as a wrapper to arrays. Pretty much likeResponse
but without any paging tokens, etc references.
- Resolved by Emiliano Balbuena
added 1 commit
- 9baf7867 - (refactor): Raw Elastic Boost and Repositories
added 1 commit
- 900c06ba - (refactor): Introduce actor to manager; changes should be in a ref
added 1 commit
- 4e1f3f64 - (chore): Exclude campaigns when returning backlog count
added 1 commit
- 3f77aa3f - (feat): Disallow editing campaign on final states
added 45 commits
- 3f77aa3f...991bd361 - 44 commits from branch
minds:master
- 990db7ff - Merge remote-tracking branch 'upstream/master' into goal/campaigns-1
- 3f77aa3f...991bd361 - 44 commits from branch
added 1 commit
- 1acfaa3e - (chore): Boost console should ignore boost campaigns
added 15 commits
- 1acfaa3e...f0b4a222 - 14 commits from branch
minds:master
- 466fa5ba - Merge remote-tracking branch 'upstream/master' into goal/campaigns-1
- 1acfaa3e...f0b4a222 - 14 commits from branch
added MR::Awaiting Review label
closed