Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 157
    • Issues 157
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !207

Closed
Opened 2 weeks ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

WIP: (feat): Boost Campaigns module

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/edgebal/engine.git goal/campaigns-1
git checkout -b edgebal/engine-goal/campaigns-1 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff edgebal/engine-goal/campaigns-1

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge edgebal:goal/campaigns-1 into master
  • Email patches
  • Plain diff
Pipeline #68525596 failed for 466fa5ba on edgebal:goal/campaigns-1
        Checking approval status

        Closed by Emiliano Balbuena 54 minutes ago

        The changes were not merged into master

        Allows commits from members who can merge to the target branch

        Deletes source branch

        • Discussion 7
        • Commits 20
        • Pipelines 18
        • Changes 19
        3/4 discussions resolved
        • Loading...
        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • ad87348f - (proto): Create campaign normalization and validation

          Compare with previous version

        • Mark Harding
          Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
          Resolved by Emiliano Balbuena 1 week ago
        • Mark Harding
          Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
          Resolved by Emiliano Balbuena 1 week ago
        • Mark Harding
          Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
          Last updated by Emiliano Balbuena 1 week ago
          Core/Boost/Campaigns/Manager.php
          118 throw new CampaignException('Campaign should have a budget');
          119 }
          120
          121 // TODO: Validate offchain balance, or set as pending for onchain
          122
          123 // Generate URN
          124
          125 $guid = $this->guid->build();
          126 $urn = "urn:campaign:{$guid}";
          127
          128 $campaign
          129 ->setUrn($urn);
          130
          131 // Normalize and validate entity URNs
          132
          133 $entityUrns = array_values(array_unique(array_filter(Text::buildArray($campaign->getEntityUrns()))));
          • Mark Harding
            Mark Harding @markeharding · 1 week ago
            Owner

            :head_bandage: not sure what we can do here to avoid function overload

          • Emiliano Balbuena @edgebal changed this line in version 3 of the diff 1 week ago

            changed this line in version 3 of the diff

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal · 1 week ago
            Developer

            Awful, eh? I was thinking on creating a Collection class as a wrapper to arrays. Pretty much like Response but without any paging tokens, etc references.

          Please register or sign in to reply
        • Mark Harding
          Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
          Resolved by Emiliano Balbuena 1 week ago
        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 75ba2677 - (proto): Campaign create/update delegates

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 91f941b7 - (chore): Use manager for listing

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 5af32004 - (feat): Validate hashtags quantity

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 9baf7867 - (refactor): Raw Elastic Boost and Repositories

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • faf259de - (fix): Populate tags on Elastic\Repo

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 47d9334d - (feat): Allow editing campaigns

          Compare with previous version

        • Emiliano Balbuena @edgebal added 2 commits 1 week ago

          added 2 commits

          • 08e40535 - (refactor): Rename to Boost\Raw
          • 02445637 - (refactor): Implement Raw Repository for Cassandra

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • c603c180 - (feat): Store campaign fields to Cassandra

          Compare with previous version

        • Emiliano Balbuena @edgebal added 2 commits 1 week ago

          added 2 commits

          • db5c05c5 - (feat): delivery status should be calculated based on timestamps
          • 1e24d47f - (feat): Handle campaign lifecycle states

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • 900c06ba - (refactor): Introduce actor to manager; changes should be in a ref

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

          added 1 commit

          • ef40f5f3 - (fix): Owner check on edit/cancel

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 6 days ago

          added 1 commit

          • 4e1f3f64 - (chore): Exclude campaigns when returning backlog count

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 5 days ago

          added 1 commit

          • 3f77aa3f - (feat): Disallow editing campaign on final states

          Compare with previous version

        • Emiliano Balbuena @edgebal added 45 commits 5 days ago

          added 45 commits

          • 3f77aa3f...991bd361 - 44 commits from branch minds:master
          • 990db7ff - Merge remote-tracking branch 'upstream/master' into goal/campaigns-1

          Compare with previous version

        • Emiliano Balbuena @edgebal added 1 commit 5 days ago

          added 1 commit

          • 1acfaa3e - (chore): Boost console should ignore boost campaigns

          Compare with previous version

        • Emiliano Balbuena @edgebal added 15 commits 3 days ago

          added 15 commits

          • 1acfaa3e...f0b4a222 - 14 commits from branch minds:master
          • 466fa5ba - Merge remote-tracking branch 'upstream/master' into goal/campaigns-1

          Compare with previous version

        • Mark Harding @markeharding added MR::Awaiting Review label 5 hours ago

          added MR::Awaiting Review label

        • Emiliano Balbuena
          Emiliano Balbuena @edgebal · 54 minutes ago
          Developer

          Superseded by !235

        • Emiliano Balbuena @edgebal closed 54 minutes ago

          closed

        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
        Please register or sign in to reply
        Assignee
        Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
        Assign to
        None
        Milestone
        None
        Assign milestone
        None
        Time tracking
        No estimate or time spent
        1
        Labels
        MR::Awaiting Review
        Assign labels
        • View project labels
        Lock merge request
        Unlocked
        7
        7 participants
        user avatar
        Rami Albatal
        user avatar
        Brian Hatchet
        user avatar
        Marcelo Rivera
        user avatar
        Ben Hayward
        user avatar
        Mark Harding
        user avatar
        Martin Santangelo
        user avatar
        Emiliano Balbuena
        Reference: minds/engine!207