Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 831
    • Issues 831
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 73
    • Merge Requests 73
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !357

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](feat): Added in buttons for play store and ios #613

Towards closing #613

image

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git ios-android-added-play-store2
git checkout -b benhayward.ben/front-ios-android-added-play-store2 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-ios-android-added-play-store2

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:ios-android-added-play-store2 into master
The source branch is 32 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #67067900 passed for 28c37730 on benhayward.ben:ios-android-added-play-store2
    Requires approval from Devs. Approved by
    Brian Hatchet
    Brian Hatchet
    Mark Harding
    Mark Harding
    Emiliano Balbuena
    Emiliano Balbuena
    Martin Santangelo
    Martin Santangelo
    Marcelo Rivera
    Marcelo Rivera
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #613

    Deletes source branch

    • Discussion 3
    • Commits 2
    • Pipelines 2
    • Changes 4
    0/1 discussion resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
      Last updated by Ben Hayward 1 week ago
      src/app/modules/mobile/marketing/marketing.component.html
      14 13 </h2>
      15
      16 14 </div>
      17 15
      18 16 <div class="m-marketing--hero--actions">
      19 17 <i class="material-icons m-mobile__giantDroid">android</i>
      18 <div class="m-marketing--hero--actions">
      19 <i class="material-icons m-mobile__giantDroid">android</i>
      20 </div>
      21
      22 <div class="mdl-card__supporting-text m-marketing--section--downloadContainer">
      23 <a href="https://geo.itunes.apple.com/us/app/minds-com/id961771928?mt=8&amp;uo=6">
      24 <img class="m-marketing--section--downloadButton m-marketing--section--downloadButton--ios"
      25 src="https://devimages-cdn.apple.com/app-store/marketing/guidelines/images/badge-download-on-the-app-store.svg">
      26 </a>
      27 <a href='https://play.google.com/store/apps/details?id=com.minds.mobile&pcampaignid=MKT-Other-global-all-co-prtnr-py-PartBadge-Mar2515-1'>
      • Mark Harding
        Mark Harding @markeharding · 1 week ago
        Owner

        I think we should replace google play with our app. Also these should be less prominent that the download link for our version

      • Ben Hayward @benhayward.ben changed this line in version 2 of the diff 1 week ago

        changed this line in version 2 of the diff

      • Ben Hayward
        Ben Hayward @benhayward.ben · 1 week ago
        Developer

        Okay, no bother, I've done that. How do you feel about the above?

      Please register or sign in to reply
    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • 28c37730 - Addressed feedback

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

      approved this merge request

    • Ben Hayward @benhayward.ben mentioned in issue #1331 9 hours ago

      mentioned in issue #1331

    • Luculent
      Luculent @luculent · 4 hours ago

      This is great :)

      However, it still requires a user to find that very tiny download link tucked away in the most innocuous place on the entire site.

      Placing the android download link in the hamburg menu is imperative.

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    7
    7 participants
    user avatar
    Mark Harding
    user avatar
    Emiliano Balbuena
    user avatar
    Martin Santangelo
    user avatar
    Marcelo Rivera
    user avatar
    Luculent
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/front!357