Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 832
    • Issues 832
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 72
    • Merge Requests 72
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !381

Open
Opened 11 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog](bug): Fix mobile group chat disapearing on keyboard #1416

Closes #1416

I've hit my head off this one for a while but the only way I could find to do it, leaves a bit more of a gap than I would like on some tested phones (see s7 edge)

S7 edge Brave:

(this is through chrome report so note that the keyboard area just appears as white)

image image

iPhone 8 Safari

image

Pixel XL Firefox

image

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git groups-chat-conversation-textbox-fix
git checkout -b benhayward.ben/front-groups-chat-conversation-textbox-fix FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-groups-chat-conversation-textbox-fix

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:groups-chat-conversation-textbox-fix into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68207872 passed for e1b46681 on benhayward.ben:groups-chat-conversation-textbox-fix
    Requires 2 more approvals from Devs.
    Marcelo Rivera
    Marcelo Rivera
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Closes #1416

    • Discussion 0
    • Commits 4
    • Pipelines 5
    • Changes 1
    • Loading...
    • Ben Hayward @benhayward.ben added 1 commit 11 hours ago

      added 1 commit

      • 660df89d - Bad commit

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 11 hours ago

      added 1 commit

      • eb3743a6 - formatting

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 11 hours ago

      added 1 commit

      • e1b46681 - accidental development artifact

      Compare with previous version

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    Reference: minds/front!381