Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 130
    • Issues 130
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 5
    • Merge Requests 5
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !234

Merged
Opened 6 days ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] client metadata and code refactor

  • client metadata added to views, votes
  • methods moved from the list stores to the models
  • fixed activity editor error
  • eslint with flow support added and configured
  • added view reporting to discovery and groups feeds (api/v2/analytics/views/)
  • added a debounce of 300ms in views reporting
  • added error messages to activity actions
  • fixed discovery gif optimization (when the image moves out of the screen)

closes #994 (closed) closes #993 (closed) closes #1000 (closed) closes #1002 (closed) closes #1003 (closed) closes #999 (closed) closes #953 (closed) closes #952 (closed) closes #997 (closed)

Edited 2 days ago by Martin Santangelo

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/msantang78/mobile-native.git sprint/HipsterHedgehog.feat.metadata.code.cleaning
git checkout -b msantang78/mobile-native-sprint/HipsterHedgehog.feat.metadata.code.cleaning FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff msantang78/mobile-native-sprint/HipsterHedgehog.feat.metadata.code.cleaning

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge msantang78:sprint/HipsterHedgehog.feat.metadata.code.cleaning into master
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
No approval required

Merged by Martin Santangelo 8 hours ago

The changes were merged into master with 816920ec

Closed #1000 (closed), #1002 (closed), #1003 (closed), #952 (closed), #953 (closed), #993 (closed), #994 (closed), #997 (closed), and #999 (closed)

Pipeline #68183013 failed for 816920ec on master
        • Discussion 2
        • Commits 8
        • Pipelines 5
        • Changes 54
        0/1 discussion resolved
        • Loading...
        • Martin Santangelo @msantang78 added 1 commit 5 days ago

          added 1 commit

          • 70fcf25a - wip: client metadata and code refactor

          Compare with previous version

        • Martin Santangelo @msantang78 added 6 commits 3 days ago

          added 6 commits

          • 5ef2e8e2 - (feat) add error log and message to votes
          • 4b0b0b9b - (fix) activity editor keeps changes on cancel
          • b07978e3 - (feat) client metadata, logic moved to models, view beacon refactor
          • 7624bda6 - (feat) eslint with flow added
          • a864d13f - (feat) implement flow in CommentList
          • e27ac3d2 - (chore) fix spec tests

          Compare with previous version

          Toggle commit list
        • Martin Santangelo @msantang78 added 2 commits 2 days ago

          added 2 commits

          • bde8f72b - (chore) fix spec tests
          • 4cd49fbb - (chore) remove console.log

          Compare with previous version

        • Martin Santangelo @msantang78 unmarked as a Work In Progress 2 days ago

          unmarked as a Work In Progress

        • Martin Santangelo @msantang78 changed milestone to %sprint: Hipster Hedgehog 2 days ago

          changed milestone to %sprint: Hipster Hedgehog

        • Martin Santangelo @msantang78 changed the description 2 times within 6 minutes 2 days ago

          changed the description 2 times within 6 minutes

        • Brian Hatchet
          Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff 2 days ago
          Last updated by Martin Santangelo 2 days ago
          .editorconfig
          10 indent_size = 2
          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 2 days ago
            Maintainer

            Did you mean to commit these changes?

          • Martin Santangelo
            Martin Santangelo @msantang78 · 2 days ago
            Maintainer

            Yeah, to standardize the base config for editors that supports .editorconfig settings.

          Please register or sign in to reply
        • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

          approved this merge request

        • Martin Santangelo @msantang78 added 21 commits 9 hours ago

          added 21 commits

          • 4cd49fbb...c4452550 - 20 commits from branch minds:master
          • 93d9008c - Merge branch 'master' into sprint/HipsterHedgehog.feat.metadata.code.cleaning

          Compare with previous version

        • Martin Santangelo @msantang78 mentioned in commit 816920ec 8 hours ago

          mentioned in commit 816920ec

        • Martin Santangelo @msantang78 merged 8 hours ago

          merged

        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
        Please register or sign in to reply
        Assignee
        None
        Assign to
        sprint: Hipster Hedgehog
        Milestone
        sprint: Hipster Hedgehog
        Assign milestone
        None
        Time tracking
        No estimate or time spent
        0
        Labels
        None
        Assign labels
        • View project labels
        Lock merge request
        Unlocked
        2
        2 participants
        user avatar
        Martin Santangelo
        user avatar
        Brian Hatchet
        Reference: minds/mobile-native!234

        Revert this merge request

        This will create a new commit in order to revert the existing changes.

        Switch branch
        Cancel
        A new branch will be created in your fork and a new merge request will be started.

        Cherry-pick this merge request

        Switch branch
        Cancel
        A new branch will be created in your fork and a new merge request will be started.