Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 159
    • Issues 159
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !227

Open
Opened 14 hours ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

(fix) Not swallowing errors and mysteriously exploding

We were swallowing and killing exceptions inside the cassandra provisioner

We weren't handling exceptions in the cockroach handler at all

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/brianhatchet/engine.git installer-fixes
git checkout -b brianhatchet/engine-installer-fixes FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff brianhatchet/engine-installer-fixes

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge brianhatchet:installer-fixes into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #68008569 passed for 47defdc4 on brianhatchet:installer-fixes
      Requires approval from Devs. Approved by
      Ben Hayward
      Ben Hayward
      Marcelo Rivera
      Marcelo Rivera
      Rami Albatal
      Rami Albatal
      Martin Santangelo
      Martin Santangelo
      Emiliano Balbuena
      Emiliano Balbuena
      Mark Harding
      Mark Harding
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request

      Allows commits from members who can merge to the target branch

      Deletes source branch

      • Discussion 0
      • Commits 1
      • Pipelines 1
      • Changes 3
      • Loading...
      • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Hipster Hedgehog 14 hours ago

        changed milestone to %sprint: Hipster Hedgehog

      • Ben Hayward @benhayward.ben approved this merge request 14 hours ago

        approved this merge request

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      Brian Hatchet's avatar Brian Hatchet @brianhatchet
      Assign to
      sprint: Hipster Hedgehog
      Milestone
      sprint: Hipster Hedgehog
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Marcelo Rivera
      user avatar
      Rami Albatal
      user avatar
      Martin Santangelo
      user avatar
      Emiliano Balbuena
      user avatar
      Mark Harding
      user avatar
      Brian Hatchet
      user avatar
      Ben Hayward
      Reference: minds/engine!227