Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 828
    • Issues 828
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 70
    • Merge Requests 70
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !277

Closed
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/CleverChipmunk](bug): (HotFix) Filtered out users banned #381

Unable to test locally

Suggested channels wont work for me locally, so if deployed this needs testing in staging. Also tried to hit the endpoint with postman and had no luck, so resolved to looking at the table layout in ./cqlsh to work out what fields the entity object has.

Ideally this should be dealt with at a lower level in ElasticSearch. I did look at Suggestions/Repository to make changes at query level, but after chatting Marcelo rightly pointed out that that wouldn't be very scalable to do for every endpoint, and have decided it best to submit a front-end fix as a patch, and recommend the banned channels get removed from the index.

Edited 1 month ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git fix-sidebar-showing-banned-users
git checkout -b benhayward.ben/front-fix-sidebar-showing-banned-users FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-fix-sidebar-showing-banned-users

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:fix-sidebar-showing-banned-users into master
  • Email patches
  • Plain diff
Pipeline #58616016 passed for 196fadd1 on benhayward.ben:fix-sidebar-showing-banned-users
    Requires 2 more approvals.

    Closed by Mark Harding 19 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Mentions #381 (closed)

    Deletes source branch

    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 1
    • Loading...
    • Ben Hayward @benhayward.ben marked as a Work In Progress 1 month ago

      marked as a Work In Progress

    • Ben Hayward @benhayward.ben unmarked as a Work In Progress 1 month ago

      unmarked as a Work In Progress

    • Ben Hayward @benhayward.ben changed title from {-WIP: Sprint/CleverChipmunk:-} Filtered out users banned #381 (closed) to {+Sprint/CleverChipmunk: (HotFix)+} Filtered out users banned #381 (closed) 1 month ago

      changed title from {-WIP: Sprint/CleverChipmunk:-} Filtered out users banned #381 (closed) to {+Sprint/CleverChipmunk: (HotFix)+} Filtered out users banned #381 (closed)

    • Ben Hayward @benhayward.ben changed the description 3 times within 2 minutes 1 month ago

      changed the description 3 times within 2 minutes

    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      Needs testing. Pretty sure banned never returned a boolean

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Funny Frog 1 month ago

      changed milestone to %sprint: Funny Frog

    • Mark Harding @markeharding closed 19 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    sprint: Funny Frog
    Milestone
    sprint: Funny Frog
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    Reference: minds/front!277