(cache)[Sprint/HipsterHedgehog](bug) Updated tags pipe to allow . character mid tag #89 (!376) · Merge Requests · Minds / Minds Frontend · GitLab

[Sprint/HipsterHedgehog](bug) Updated tags pipe to allow . character mid tag #89

Closes #89

Many thanks to @edgebal for helping me get it to take into consideration a space after the period character.

Edited 1 hour ago by Ben Hayward

Request to merge benhayward.ben:period-char-username-cutoff-tag-fix into master

The source branch is 1 commit behind the target branch

Open in Web IDE

0/1 discussion resolved

Brian Hatchet @brianhatchet approved this merge request 20 hours ago

approved this merge request
Ben Hayward @benhayward.ben added 1 commit 2 hours ago
added 1 commit

1dbbf3d0 - Update tags.spec.ts

Compare with previous version
Ben Hayward @benhayward.ben · 2 hours ago

Developer

I've been thinking about this and is this what we want to do @edgebal. take for example there, i tagged you at the end of the sentence and there is a full stop. Will this change not mess up a lot of existing tags on the site?
Ben Hayward @benhayward.ben · 2 hours ago

Developer

Maybe we should only do this if the dot is not followed by a space?
Ben Hayward @benhayward.ben added 1 commit 1 hour ago
added 1 commit

b445b988 - Update tags.ts

Compare with previous version
Ben Hayward @benhayward.ben added 2 commits 1 hour ago
added 2 commits

5523371d - Updated regex

7fe81df8 - removed fdesc

Compare with previous version
Ben Hayward @benhayward.ben changed the description 1 hour ago

changed the description

Brian Hatchet @brianhatchet started a discussion on the diff 1 hour ago

src/app/common/pipes/tags.spec.ts

  expect(transformedString).toContain('<a class="tag"');
  });
  it('should transform when @ followed by `.com`', () => {
  const pipe = new TagsPipe(featuresServiceMock);

Emiliano Balbuena @edgebal approved this merge request 52 minutes ago

approved this merge request
You're only seeing other activity in the feed. To add a comment, switch to one of the following options.

Please register or sign in to reply