[Sprint/HipsterHedgehog] (feat): update language on strike emails
Request to merge eiennohi:sprint/HipsterHedgehog.feat.update-language-on-strike-emails into master
The source branch is 6 commits behind the target branch
0/4 discussions resolved
1 It looks like your post has been tagged as **(<?php echo $vars['tag']; ?> - <?php echo $vars['subaction']; ?>)** for containing (<?php echo $vars['subaction']; ?>) that is not safe for the workplace. This is your <?php echo $vars['strikeNumber']; ?> strike. 2 3 Don’t worry...your post will not be removed and your channel is not at risk of being banned. Because you have received three strikes in this category, your content will now be automatically tagged as **(<?php echo $vars['tag']; ?> - <?php echo $vars['subaction']; ?>)**. 
MaintainerAll the new emails have been pretty rich text. Are we sure we want these in plain text?
Please register or sign in to reply1 It looks like your post has been tagged as **(<?php echo $vars['tag']; ?> - <?php echo $vars['subaction']; ?>)** for containing (<?php echo $vars['subaction']; ?>) that is not safe for the workplace. This is your <?php echo $vars['strikeNumber']; ?> strike. 2 3 Don’t worry...your post will not be removed and your channel is not at risk of being banned. Because you have received three strikes in this category, your content will now be automatically tagged as **(<?php echo $vars['tag']; ?> - <?php echo $vars['subaction']; ?>)**. 4 5 If you believe that a mistake has been made, you may appeal this decision to a jury of your peers. If you wish to learn more about our policy and appeal process, please visit our Content Policy. - Maintainer
Case in point, these calls to actions should be lins to our content policy
64 $vars['strikeNumber'] = $this->getStrikeNumberFriendlyString($strike); 65 66 $subject = 'Your post was tagged as NSFW' . '(' . ucfirst($vars['strikeNumber']) . ' Notice)'; 52 67 break; 53 68 } 54 69 55 $this->campaign->setUser($owner); 56 $this->campaign->setTemplate('moderation-strike.md'); 57 $this->campaign->setSubject('You have received a strike'); 58 $this->campaign->setVars([ 70 $vars[] = [ 59 71 'type' => $type, 60 72 'action' => $action, 61 73 //'reason' => $reason, 62 ]); 74 ]; - Maintainer
We should enable the click back mechanisms for all our emails. The email campaigns have a pretty seamless mechanism for creating CTAs and that get registered by the router and tracked in our activity index.
180 183 ->setTimestamp($report->getTimestamp()); // Strike is recored for date of first report 181 184 182 185 $count = $this->strikesManager->countStrikesInTimeWindow($strike, $this->strikesManager::STRIKE_TIME_WINDOW); 186 $retentionCount = $this->strikesManager->countStrikesInTimeWindow($strike, $this->strikesManager::STRIKE_RETENTION_WINDOW); 187 188 $strike->setNumber($retentionCount ?? 1); 183 189 184 190 if (!$count) { 185 191 $this->strikesManager->add($strike); 186 192 } 187 193 188 194 // If 3 or more strikes, ban or apply NSFW lock 189 if ($this->strikesManager->countStrikesInTimeWindow($strike, $this->strikesManager::STRIKE_RETENTION_WINDOW) >= 3) { 195 if ($retentionCount >= 3) { - Maintainer
These numeric values should be constants.
