[Sprint/HipsterHedgehog](bug): Stopping banned users from showing in sidebar
Closes https://gitlab.com/minds/engine/issues/381
I also thought the component should have some test coverage.
Request to merge benhayward.ben:banned-channels-suggested-sidebar-fix into master
The source branch is 1 commit behind the target branch
0/1 discussion resolved
Last updated by Ben Hayward43 43 }); 44 44 for (let suggestion of response.suggestions) { 45 45 const removed = this.storage.get(`user:suggestion:${suggestion.entity_guid}:removed`); 46 if (!removed) { 46 if (!removed && suggestion.banned !== "yes") { - Maintainer
I keep seeing these "yes" in the code base which makes we wonder why they aren't bools. Not a change you need to make, but I will ask about it, because it feels like we're asking for trouble.
DeveloperAgreed completely but I was just mimicking the value held by an entity already. Would be wary of changing it here incase somewhere else in the codebase it's expecting a string rather than a bool.
What do you think best?
Please register or sign in to replyapproved this merge request
