Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Marcelo Rivera@eiennohi
Report abuse

[Sprint/HipsterHedgehog] (feat): clicks on etag blur should propagate to remind and viceversa

closes #1444

Request to merge eiennohi:sprint/HipsterHedgehog.feat.click-on-etag-blur-should-propagate-to-remind-and-viceversa into master
Open in Web IDE
Pipeline #67738993 passed for 10c65c2c on eiennohi:sprint/HipsterHedgehog.feat.click-on-etag-blur-should-propagate-to-remind-and-viceversa
    Requires approval from Devs. Approved by
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #1444

    Deletes source branch

    0/1 discussion resolved
    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet started a discussion on the diff
      Last updated by Marcelo Rivera
      src/app/modules/legacy/components/cards/activity/activity.html
      61 61
      62 62 <div m-read-more class="mdl-card__supporting-text message m-mature-message" [class.m-activity--message-remind]="activity.remind_object"
      63 63 [hidden]="!activity.message || editing">
      64 <a class="m-mature-text-toggle" (click)="activity.mature_visibility = !activity.mature_visibility"
      64 <a class="m-mature-text-toggle" (click)="toggleMatureVisibility()"
      65 65 *ngIf="attachment.shouldBeBlurred(activity) || attachment.isForcefullyShown(activity)"
      66 66 [ngClass]="{ 'mdl-color-text--red-500': attachment.isForcefullyShown(activity) }">
      • Brian Hatchet
        Brian Hatchet :speech_balloon: @brianhatchet ·
        Maintainer

        Looks like this already exists, so this isn't a required change, just a question.

        What the hell is "isForcefullyShown()"?

      • Marcelo Rivera
        Marcelo Rivera @eiennohi ·
        Developer

        It didn't already exist. I moved that code to a method, and added more code.

        The old isForcefullyShown() method, on the other hand, checks activity.mature_visibility. The logic is nsfw content is hidden by default unless you force it to show by clicking on it

      Please register or sign in to reply
    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request

      approved this merge request

    Please register or sign in to reply