Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 137
    • Issues 137
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 6
    • Merge Requests 6
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !228

Merged
Opened 6 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](bug): Removed linking and conditionally shown globe icon in blogs

Conflict with !224 Will resolve once that is merged in, please look at that first.

My logic here was that the globe button is probably just meant to be for license due to its location (next to the license text), and as such, it shouldn't be directing anywhere, or shown if there is no license set.

Edited 6 days ago by Ben Hayward
Request to merge benhayward.ben:globe-icon-fix-blog-post-774 into master
  • Email patches
  • Plain diff
Pipeline #66785467 passed for a5a20b2e on benhayward.ben:globe-icon-fix-blog-post-774
    Merge request approved. Approved by
    Brian Hatchet
    Brian Hatchet

    Merged by Martin Santangelo 1 hour ago

    The changes were merged into master with e5f8367f

    The source branch has been deleted

    Allows commits from members who can merge to the target branch

    Pipeline #67732545 failed for e5f8367f on master
          • Discussion 0
          • Commits 2
          • Pipelines 2
          • Changes 2
          • Loading...
          • Ben Hayward @benhayward.ben added 1 commit 6 days ago

            added 1 commit

            • a5a20b2e - Added snapshot

            Compare with previous version

          • Ben Hayward @benhayward.ben changed the description 6 days ago

            changed the description

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

            approved this merge request

          • Martin Santangelo @msantang78 merged 1 hour ago

            merged

          • Martin Santangelo @msantang78 mentioned in commit e5f8367f 1 hour ago

            mentioned in commit e5f8367f

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          3
          3 participants
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          Reference: minds/mobile-native!228

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.