Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 143
    • Issues 143
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !235

Open
Opened 3 hours ago by Juan Manuel Solaro@juanmsolaro
  • Report abuse
Report abuse

[Sprint/HipsterHedgehog] (fix) error message should appear for banned users

closes #996 Added await to method call

Edited 3 hours ago by Juan Manuel Solaro

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/juanmsolaro/mobile-native.git sprint/HipsterHedgehog.fix.login.keeps.spinning.and.not.showing.error.for.banned.users
git checkout -b juanmsolaro/mobile-native-sprint/HipsterHedgehog.fix.login.keeps.spinning.and.not.showing.error.for.banned.users FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff juanmsolaro/mobile-native-sprint/HipsterHedgehog.fix.login.keeps.spinning.and.not.showing.error.for.banned.users

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge juanmsolaro:sprint/HipsterHedgehog.fix.login.keeps.spinning.and.not.showing.error.for.banned.users into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #67391839 passed for 00277b11 on juanmsolaro:sprint/HipsterHedgehog.fix.login.keeps.spinning.and.not.showing.error.for.banned.users
    Merge request approved. Approved by
    Ben Hayward
    Ben Hayward
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Closes #996

    • Discussion 0
    • Commits 1
    • Pipelines 1
    • Changes 1
    • Loading...
    • Juan Manuel Solaro @juanmsolaro changed the description 3 hours ago

      changed the description

    • Ben Hayward @benhayward.ben approved this merge request 4 minutes ago

      approved this merge request

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Ben Hayward
    user avatar
    Juan Manuel Solaro
    Reference: minds/mobile-native!235