Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 161
    • Issues 161
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 38
    • Merge Requests 38
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !214

Merged
Opened 1 day ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

(fix) Firehose all entities saving properly

This iteration of the firehose does a bunch of things.

It properly saves videos, images and blogs to both elasticsearch and cassandra.

Finally got the mappings working properly. moderated entities will update elasticsearch with moderator_guid and @moderated

We need to insert the object:blog, object:video and object:image fields in their respective types in elasticsearch (calls are in postman)

I have also updated the elasticsearch_provisioner to add those fields for development

Edited 1 day ago by Brian Hatchet

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/brianhatchet/engine.git firehose-images-video-saving-properly
git checkout -b brianhatchet/engine-firehose-images-video-saving-properly FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff brianhatchet/engine-firehose-images-video-saving-properly

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge brianhatchet:firehose-images-video-saving-properly into master
  • Email patches
  • Plain diff
Pipeline #67369187 failed for b1e8bbbd on brianhatchet:firehose-images-video-saving-properly
      Requires 2 more approvals from Devs.
      Mark Harding
      Mark Harding
      Emiliano Balbuena
      Emiliano Balbuena
      Marcelo Rivera
      Marcelo Rivera
      Ben Hayward
      Ben Hayward
      Rami Albatal
      Rami Albatal

      Merged by Mark Harding 7 minutes ago

      The changes were merged into master with f0bb745e

      Allows commits from members who can merge to the target branch

      Pipeline #67369259 failed for f0bb745e on master
            • Discussion 10
            • Commits 11
            • Pipelines 8
            • Changes 11
            5/5 discussions resolved
            • Loading...
            • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Hipster Hedgehog 1 day ago

              changed milestone to %sprint: Hipster Hedgehog

            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

              added 1 commit

              • 240e5431 - Everything working and saving edition

              Compare with previous version

            • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 1 day ago

              unmarked as a Work In Progress

            • Brian Hatchet :speech_balloon: @brianhatchet changed title from WIP: Firehose images video saving properly to Firehose all entities saving properly 1 day ago

              changed title from WIP: Firehose images video saving properly to Firehose all entities saving properly

            • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 day ago

              changed the description

            • Brian Hatchet :speech_balloon: @brianhatchet assigned to @brianhatchet 1 day ago

              assigned to @brianhatchet

            • Brian Hatchet :speech_balloon: @brianhatchet changed title from Firehose all entities saving properly to (fix) Firehose all entities saving properly 1 day ago

              changed title from Firehose all entities saving properly to (fix) Firehose all entities saving properly

            • Emiliano Balbuena
              Emiliano Balbuena @edgebal started a discussion on an old version of the diff 1 day ago
              Resolved by Brian Hatchet 19 hours ago
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal started a discussion on an old version of the diff 1 day ago
              Resolved by Brian Hatchet 19 hours ago
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal started a discussion on an old version of the diff 1 day ago
              Resolved by Brian Hatchet 19 hours ago
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal started a discussion on an old version of the diff 1 day ago
              Resolved by Brian Hatchet 19 hours ago
            • Emiliano Balbuena
              Emiliano Balbuena @edgebal started a discussion on an old version of the diff 1 day ago
              Resolved by Brian Hatchet 19 hours ago
            • Brian Hatchet :speech_balloon: @brianhatchet resolved all discussions 19 hours ago

              resolved all discussions

            • Brian Hatchet :speech_balloon: @brianhatchet added 8 commits 19 hours ago

              added 8 commits

              • 240e5431...335d885a - 6 commits from branch minds:master
              • 1d623fd7 - Merge remote-tracking branch 'upstream/master' into firehose-images-video-saving-properly
              • fc93117d - MR changes

              Compare with previous version

            • Emiliano Balbuena @edgebal approved this merge request 19 hours ago

              approved this merge request

            • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 17 hours ago

              added 5 commits

              • fc93117d...01d29bd9 - 4 commits from branch minds:master
              • ff511fe3 - Merge remote-tracking branch 'upstream/master' into firehose-images-video-saving-properly

              Compare with previous version

            • Mark Harding @markeharding added 1 commit 28 minutes ago

              added 1 commit

              • f33aeaa3 - (chore): reverted unneeded spacing/line changes

              Compare with previous version

            • Mark Harding @markeharding added 2 commits 7 minutes ago

              added 2 commits

              • bac2b475 - (chore): return a urn for blogs
              • b1e8bbbd - (chore): if not urn, use a fake one

              Compare with previous version

            • Mark Harding @markeharding merged 7 minutes ago

              merged

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            Assignee
            Brian Hatchet's avatar Brian Hatchet @brianhatchet
            Assign to
            sprint: Hipster Hedgehog
            Milestone
            sprint: Hipster Hedgehog
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            7
            7 participants
            user avatar
            Mark Harding
            user avatar
            Emiliano Balbuena
            user avatar
            Marcelo Rivera
            user avatar
            Ben Hayward
            user avatar
            Rami Albatal
            user avatar
            Martin Santangelo
            user avatar
            Brian Hatchet
            Reference: minds/engine!214

            Revert this merge request

            This will create a new commit in order to revert the existing changes.

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.

            Cherry-pick this merge request

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.