Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 141
    • Issues 141
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 11
    • Merge Requests 11
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !234

Open
Opened 15 minutes ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

WIP: [Sprint/HipsterHedgehog] client metadata and code refactor

  • client metadata added to views, votes
  • methods moved from the list stores to the models
  • fixed activity editor error
  • eslint with flow support added and configured
  • added view reporting to discovery and groups feeds (api/v2/analytics/views/)
  • added a debounce of 300ms in views reporting
  • added error messages to activity actions

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/msantang78/mobile-native.git sprint/HipsterHedgehog.feat.metadata.code.cleaning
git checkout -b msantang78/mobile-native-sprint/HipsterHedgehog.feat.metadata.code.cleaning FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff msantang78/mobile-native-sprint/HipsterHedgehog.feat.metadata.code.cleaning

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge msantang78:sprint/HipsterHedgehog.feat.metadata.code.cleaning into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
No approval required
This is a Work in Progress
You can merge this merge request manually using the
  • Discussion 0
  • Commits 1
  • Pipelines 1
  • Changes 47
  • Loading...
  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
None
Assign to
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • View project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Martin Santangelo
Reference: minds/mobile-native!234